lwip weave tunnel test 02 #362
Conversation
@jenniexie, thanks for sharing broader context; however, non-Google Github users cannot access such documents. I would recommend creating a Github issue, and managing the content there. |
| @@ -168,6 +168,30 @@ def getNodeWeaveIPAddress(self, node_id=None, state=None): | |||
| return addr | |||
| return None | |||
|
|
|||
| def getNodeInterfaceWeaveIPAddress(self, interface_id, node_id, state=None): | |||
There was a problem hiding this comment.
How does this control / influence whether that address is IPv4 or IPv6. Ostensibly that address should only be IPv6; however, the documentation should be clear about that fact and the code should, potentially, have an assertion or some such to trap / catch an IPv4 address that might "bubble up" through to this interface.
There was a problem hiding this comment.
Hi Grant:
Do you mean add a check to make sure there is ipv6 address in the node's address list before we do IP.prefixMatchAddress(weave_global_prefix, addr) in line 191?
This function will return weave ip address, which should be ipv6 address by default from my understanding.
Sure, I will remove the google doc and add an issue with information there. |
jenniexie
force-pushed
the
jexie/lwip_tunnel_test02_pr
branch
from
7d7db91 to
0008762
Compare
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
==========================================
+ Coverage 54.35% 54.36% +<.01%
==========================================
Files 341 341
Lines 58207 58207
==========================================
+ Hits 31641 31643 +2
+ Misses 26566 26564 -2
Continue to review full report at Codecov.
|
|
Merging #362 into master will increase coverage by 1.61%. |
enabled lwip tunnel test 02
#364