This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
[woble] Add single BLE connection option. #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
==========================================
- Coverage 54.51% 54.46% -0.06%
==========================================
Files 341 340 -1
Lines 58548 58425 -123
==========================================
- Hits 31919 31821 -98
+ Misses 26629 26604 -25
Continue to review full report at Codecov.
|
jaylogue
reviewed
Oct 24, 2019
| @@ -375,7 +375,11 @@ void BLEManagerImpl::DriveBLEState(void) | |||
| WEAVE_ERROR err = WEAVE_NO_ERROR; | |||
|
|
|||
| // If the application has enabled WoBLE and BLE advertising... | |||
There was a problem hiding this comment.
Please update the comment to describe the new behavior.
There was a problem hiding this comment.
Ok, added to the comment by adding another one inside the condition after the ...
Wasn't sure of the best way to interleave conditional code and extending the comment.
Let me know if you have a better suggestion.
jaylogue
reviewed
Oct 24, 2019
src/adaptations/device-layer/include/Weave/DeviceLayer/WeaveDeviceConfig.h
Show resolved
Hide resolved
jaylogue
approved these changes
Oct 24, 2019
…an active connection.
turon
force-pushed
the
pr/woble/single-connection
branch
from
960403e to
465c4f2
Compare
robszewczyk
approved these changes
Oct 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an option to disable WoBLE advertisements while a WoBLE connection is active.