Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support changing null to false in update-bcd #1473

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented May 19, 2024

Fixes #1042.

@queengooborg queengooborg temporarily deployed to mdn-bcd-collector-pr-1473 May 19, 2024 16:42 Inactive
foolip added a commit to foolip/browser-compat-data that referenced this pull request May 19, 2024
@foolip
Copy link
Member Author

foolip commented May 19, 2024

mdn/browser-compat-data#23129 shows the changes that the collector can make after this fix.

@foolip foolip requested a review from queengooborg May 19, 2024 16:44
@queengooborg
Copy link
Member

This is looking good, but since the commits are signed, we can't merge this just yet! Could you sign the commits and re-push?

@foolip
Copy link
Member Author

foolip commented May 30, 2024

@queengooborg done!

@queengooborg queengooborg merged commit 79c315c into main Jun 5, 2024
5 checks passed
@queengooborg queengooborg deleted the null-to-false branch June 5, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update-bcd: null is not replaced with false
2 participants