fix: fix set Element.style.cssText API.

openwebf · Aug 11, 2023 · 853b72e · 853b72e
1 parent 9c143d1
commit 853b72e
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/bridge/core/css/inline_css_style_declaration.cc b/bridge/core/css/inline_css_style_declaration.cc
@@ -74,6 +74,10 @@ ScriptValue InlineCssStyleDeclaration::item(const AtomicString& key, ExceptionSt
 bool InlineCssStyleDeclaration::SetItem(const AtomicString& key,
  const ScriptValue& value,
  ExceptionState& exception_state) {
+ if (IsPrototypeMethods(key)) {
+ return false;
+ }
+
  std::string propertyName = key.ToStdString(ctx());
  return InternalSetProperty(propertyName, value.ToLegacyDOMString());
 }

diff --git a/integration_tests/specs/cssom/cssom-setCssText-serialize.html b/integration_tests/specs/cssom/cssom-setCssText-serialize.html
@@ -0,0 +1,23 @@
+<!DOCTYPE html>
+<html>
+<head>
+ <title>CSSOM Parsing Test: getting cssText must return the result of serializing the CSS declaration blocks.</title>
+ <link rel="author" title="Paul Irish" href="mailto:paul.irish@gmail.com">
+ <link rel="help" href="http://www.w3.org/TR/cssom-1/#the-cssstyledeclaration-interface">
+
+ <meta name="flags" content="dom">
+</head>
+
+<body>
+<div id="log"></div>
+<div id="box"></div>
+<script>
+ var style = document.getElementById('box').style;
+ style.cssText = 'left: 10px';
+ assert_equals(style.left, '10px');
+ style.cssText = 'right: 20px; left: 10px';
+ assert_equals(style.left, '10px');
+ assert_equals(style.right, '20px');
+</script>
+</body>
+</html>