Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error which calculate child to parent position not include scrollLeft and scrollTop #2

Merged
merged 7 commits into from
Aug 15, 2022
Merged

fix error which calculate child to parent position not include scrollLeft and scrollTop #2

merged 7 commits into from
Aug 15, 2022

Conversation

pba-cra
Copy link
Contributor

@pba-cra pba-cra commented Jul 27, 2022

fix error which calculate child to parent position not include scrollLeft and scrollTop

@DWarrior222 DWarrior222 mentioned this pull request Aug 2, 2022
Closed
@zjt123 zjt123 mentioned this pull request Aug 3, 2022
Closed
@pba-cra pba-cra merged commit 45a07cd into openwebf:main Aug 15, 2022
@zjt123 zjt123 mentioned this pull request Aug 26, 2022
Closed
1 task
@pba-cra pba-cra mentioned this pull request Oct 12, 2022
Closed
1 task
@liuzitong123a liuzitong123a mentioned this pull request Oct 21, 2022
Closed
1 task
@devjiangzhou devjiangzhou mentioned this pull request Nov 20, 2022
Closed
1 task
@pba-cra pba-cra mentioned this pull request Nov 30, 2022
Open
1 task
yifei8 added a commit that referenced this pull request Dec 27, 2022
@yifei8
type 'Null' is not a subtype of type ...
66fbb3b 
```log
type 'Null' is not a subtype of type 'ContainerParentDataMixin<RenderBox>' in type cast
    #0      RenderBoxModel.getPreviousSibling (package:webf/src/rendering/box_model.dart:1371:63)
    #1      Element.addToContainingBlock (package:webf/src/dom/element.dart:776:50)
    #2      Element._updateRenderBoxModelWithPosition.<anonymous closure> (package:webf/src/dom/element.dart:756:15)
    #3      List.forEach (dart:core-patch/growable_array.dart:433:8)
    #4      Element._updateRenderBoxModelWithPosition (package:webf/src/dom/element.dart:755:32)
    #5      Element.setRenderStyleProperty (package:webf/src/dom/element.dart:1247:9)
    #6      Element.setRenderStyle (package:webf/src/dom/element.dart:1536:5)
    #7      Element._onStyleChanged (package:webf/src/dom/element.dart:1613:7)
    #8      CSSStyleDeclaration._emitPropertyChanged (package:webf/src/css/style_declaration.dart:566:22)
    #9      CSSStyleDeclaration.flushPendingProperties (package:webf/src/css/style_declaration.dart:468:7)
    #10     Element.attachTo (packa

```
@zjt123 zjt123 mentioned this pull request Mar 2, 2023
Closed
1 task
@NoahJinnn NoahJinnn mentioned this pull request May 12, 2023
Open
1 task
@helixs helixs mentioned this pull request Jul 5, 2023
Closed
1 task
@zjt123 zjt123 mentioned this pull request Jul 21, 2023
Merged
@looseyi looseyi mentioned this pull request Aug 7, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 8, 2023
@looseyi @edmond-l-20230331 @andycall
fix: fix css lenght parse stack overflow with font: inherit property (#…
e21a117 
…449)

2023-08-07 20:47:25.935739+0800 Runner[7889:8608870] flutter: Stack
Overflow
#0 _LinkedHashMapMixin.[]
(dart:collection-patch/compact_hash.dart:601:3)
#1 CSSStyleDeclaration.getPropertyValue
(package:webf/src/css/style_declaration.dart:150:30)
#2 CSSLength.parseLength
(package:webf/src/css/values/length.dart:590:68)
#3 CSSLength.parseLength
(package:webf/src/css/values/length.dart:590:16)
#4 CSSLength.parseLength
(package:webf/src/css/values/length.dart:590:16)
#5 CSSLength.parseLength
(package:webf/src/css/values/length.dart:590:16)
...
#2116 Element.setRenderStyleProperty
(package:webf/src/dom/element.dart:1402:11)
#2117 Element.setRenderStyle (package:webf/src/dom/element.dart:1777:5)
#2118 Element._onStyleChanged (package:webf/src/dom/element.dart:1849:7)
#2119 CSSStyleDeclaration._emitPropertyChanged
(package:webf/src/css/style_declaration.dart:685:22)
#2120 CSSStyleDeclaration.flushPendingProperties
(package:webf/src/css/style_declaration.dart:457:7)
#2121   Element.attachTo (package:webf/src/dom/element.dart:997:13)
#2122 Element.ensureChildAttached
(package:webf/src/dom/element.dart:1061:17)
#2123 Element.didAttachRenderer
(package:webf/src/dom/element.dart:600:5)
#2124   Element.attachTo (package:webf/src/dom/element.dart:999:7)
#2125 Element.ensureChildAttached
(package:webf/src/dom/element.dart:1061:17)
#2126 Element.didAttachRenderer
(package:webf/src/dom/element.dart:600:5)
#2127   Element.attachTo (package:webf/src/dom/element.dart:999:7)
#2128 Element.ensureChildAttached
(package:webf/src/dom/element.dart:1061:17)
#2129 Element.didAttachRenderer
(package:webf/src/dom/element.dart:600:5)
#2130   Element.attachTo (package:webf/src/dom/element.dart:999:7)
#2131   Element.appendChild (package:webf/src/dom/element.dart:1094:15)
#2132 WebFViewController.insertAdjacentNode
(package:webf/src/launcher/controller.dart:461:16)
#2133   flushUICommand (package:webf/src/bridge/to_native.dart:524:16)
#2134 flushUICommandWithContextId
(package:webf/src/bridge/to_native.dart:469:5)
#2135   _flushUICommand (package:webf/src/bridge/from_native.dart:371:3)
#2136   _FfiCallback_flushUICommand (dart:ffi)
#2137   FfiTrampoline__evaluateQuickjsByteCode (dart:ffi)
#2138 evaluateQuickjsByteCode
(package:webf/src/bridge/to_native.dart:221:40)
#2139   evaluateScripts (package:webf/src/bridge/to_native.dart:166:19)
#2140   _RootZone.runUnary (dart:async/zone.dart:1660:54)
#2141   _FutureListener.handleValue (dart:async/future_impl.dart:147:18)
#2142 Future._propagateToListeners.handleValueCallback
(dart:async/future_impl.dart:767:45)
#2143 Future._propagateToListeners (dart:async/future_impl.dart:796:13)
#2144   Future._completeWithValue (dart:async/future_impl.dart:567:5)
#2145   _RootZone.runUnary (dart:async/zone.dart:1660:54)
#2146   _FutureListener.handleValue (dart:async/future_impl.dart:147:18)
#2147 Future._propagateToListeners.handleValueCallback
(dart:async/future_impl.dart:767:45)
#2148 Future._propagateToListeners (dart:async/future_impl.dart:796:13)
#2149   Future._completeWithValue (dart:async/future_impl.dart:567:5)
#2150   _RootZone.runUnary (dart:async/zone.dart:1660:54)
#2151   _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
#2152   _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)

Co-authored-by: edmond.l <edmond.l@binance.com>
Co-authored-by: TIANCHENG <dongtiangche@outlook.com>
@dmqweb dmqweb mentioned this pull request Jun 12, 2024
Closed
1 task
andycall added a commit that referenced this pull request Sep 9, 2024
@andycall
Fix: fix dart type error when attach flex layout underneath of Flutte…
a3f733b 
…r ListView (#650)

```
══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
The following _TypeError was thrown during performLayout():
type 'ParentData' is not a subtype of type 'RenderLayoutParentData' in type cast

The relevant error-causing widget was:
  WebF WebF:file:///Users/user/Desktop/Binance/webf/webf/example/lib/main.dart:214:16

When the exception was thrown, this was the stack:
#0      RenderFlexLayout._needToStretchChildCrossSize (package:webf/src/rendering/flex.dart:2243:69)
#1      RenderFlexLayout._getAutoMinSize (package:webf/src/rendering/flex.dart:491:38)
#2      RenderFlexLayout._getMinMainAxisSize (package:webf/src/rendering/flex.dart:369:28)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andycall andycall andycall left review comments

@xuzhongpeng xuzhongpeng xuzhongpeng approved these changes

@yifei8 yifei8 yifei8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pba-cra @andycall @xuzhongpeng @yifei8