Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove the navigator.connection API. #411

Merged
merged 2 commits into from
Jul 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions bridge/polyfill/src/connection.ts

This file was deleted.

2 changes: 0 additions & 2 deletions bridge/polyfill/src/navigator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@
*/

import { webf } from './webf';
import connection from './connection';

export const navigator = {
connection,
// UA is read-only.
get userAgent() {
return webf.invokeModule('Navigator', 'getUserAgent');
Expand Down
2 changes: 0 additions & 2 deletions bridge/polyfill/src/webf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@

import { addWebfModuleListener, webfInvokeModule, clearWebfModuleListener, removeWebfModuleListener } from './bridge';
import { methodChannel, triggerMethodCallHandler } from './method-channel';
import { dispatchConnectivityChangeEvent } from "./connection";

addWebfModuleListener('Connection', (event, data) => dispatchConnectivityChangeEvent(event));
addWebfModuleListener('MethodChannel', (event, data) => triggerMethodCallHandler(data[0], data[1]));

export const webf = {
Expand Down
5 changes: 0 additions & 5 deletions integration_tests/specs/navigator/navigator.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
describe('Navigator', () => {
it('connectivity', async () => {
let connection = await navigator.connection.getConnectivity();
expect(connection.isConnected).toBeTrue();
});

it('hardwareConcurrency', () => {
expect(navigator.hardwareConcurrency > 0).toBeTrue();
});
Expand Down
2 changes: 0 additions & 2 deletions webf/example/macos/Flutter/GeneratedPluginRegistrant.swift
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,10 @@
import FlutterMacOS
import Foundation

import connectivity_plus
import shared_preferences_foundation
import webf

func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) {
ConnectivityPlugin.register(with: registry.registrar(forPlugin: "ConnectivityPlugin"))
SharedPreferencesPlugin.register(with: registry.registrar(forPlugin: "SharedPreferencesPlugin"))
WebFPlugin.register(with: registry.registrar(forPlugin: "WebFPlugin"))
}
2 changes: 1 addition & 1 deletion webf/example/macos/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ post_install do |installer|
installer.pods_project.targets.each do |target|
flutter_additional_macos_build_settings(target)
target.build_configurations.each do |config|
config.build_settings['MACOSX_DEPLOYMENT_TARGET'] = '10.11'
config.build_settings['MACOSX_DEPLOYMENT_TARGET'] = '10.14'
end
end
end
4 changes: 0 additions & 4 deletions webf/example/macos/Runner.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -260,17 +260,13 @@
);
inputPaths = (
"${PODS_ROOT}/Target Support Files/Pods-Runner/Pods-Runner-frameworks.sh",
"${BUILT_PRODUCTS_DIR}/ReachabilitySwift/Reachability.framework",
"${BUILT_PRODUCTS_DIR}/connectivity_plus/connectivity_plus.framework",
"${BUILT_PRODUCTS_DIR}/shared_preferences_foundation/shared_preferences_foundation.framework",
"${PODS_ROOT}/../Flutter/ephemeral/.symlinks/plugins/webf/macos/libwebf.dylib",
"${PODS_ROOT}/../Flutter/ephemeral/.symlinks/plugins/webf/macos/libquickjs.dylib",
"${BUILT_PRODUCTS_DIR}/webf/webf.framework",
);
name = "[CP] Embed Pods Frameworks";
outputPaths = (
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Reachability.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/connectivity_plus.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/shared_preferences_foundation.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/libwebf.dylib",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/libquickjs.dylib",
Expand Down
3 changes: 0 additions & 3 deletions webf/example/windows/flutter/generated_plugin_registrant.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,9 @@

#include "generated_plugin_registrant.h"

#include <connectivity_plus/connectivity_plus_windows_plugin.h>
#include <webf/webf_plugin.h>

void RegisterPlugins(flutter::PluginRegistry* registry) {
ConnectivityPlusWindowsPluginRegisterWithRegistrar(
registry->GetRegistrarForPlugin("ConnectivityPlusWindowsPlugin"));
WebfPluginRegisterWithRegistrar(
registry->GetRegistrarForPlugin("WebfPlugin"));
}
1 change: 0 additions & 1 deletion webf/example/windows/flutter/generated_plugins.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#

list(APPEND FLUTTER_PLUGIN_LIST
connectivity_plus
webf
)

Expand Down
1 change: 0 additions & 1 deletion webf/lib/module.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
export 'src/module/module_manager.dart';
export 'src/module/async_storage.dart';
export 'src/module/clipboard.dart';
export 'src/module/connection.dart';
export 'src/module/fetch.dart';
export 'src/module/method_channel.dart';
export 'src/module/schedule_frame.dart';
Expand Down
80 changes: 0 additions & 80 deletions webf/lib/src/module/connection.dart

This file was deleted.

1 change: 0 additions & 1 deletion webf/lib/src/module/module_manager.dart
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ void _defineModuleCreator() {
_isDefined = true;
_defineModule((ModuleManager? moduleManager) => AsyncStorageModule(moduleManager));
_defineModule((ModuleManager? moduleManager) => ClipBoardModule(moduleManager));
_defineModule((ModuleManager? moduleManager) => ConnectionModule(moduleManager));
_defineModule((ModuleManager? moduleManager) => FetchModule(moduleManager));
_defineModule((ModuleManager? moduleManager) => MethodChannelModule(moduleManager));
_defineModule((ModuleManager? moduleManager) => NavigationModule(moduleManager));
Expand Down
1 change: 0 additions & 1 deletion webf/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ dependencies:
quiver: ^3.2.1 # Pure dart module.
vector_math: ^2.1.2 # Pure dart module.
source_span: ^1.9.0 # Pure dart module.
connectivity_plus: ^3.0.6 # No AndroidX used.
shared_preferences: 2.2.0 # No AndroidX used.
archive: ^3.3.7 # Pure dart module.
web_socket_channel: ^2.2.0
Expand Down
Loading