-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text layout & Sliver update & Flow Refactor #454
Open
pba-cra
wants to merge
42
commits into
main
Choose a base branch
from
feature/text-flow-sliver-css
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycall
force-pushed
the
feature/text-flow-sliver-css
branch
from
August 10, 2023 07:51
2ec2b48
to
4621d58
Compare
andycall
force-pushed
the
feature/text-flow-sliver-css
branch
from
August 11, 2023 14:30
1767140
to
e6f845d
Compare
…bf into feature/text-flow-sliver-css
…ace-btween and flex main axis child margin set
1. fix flex and flow negative margin error 2. fix line join lineExtent not right 3. text line box line extent error 4. first more-line text with other text error 5. flowlayout inline render setChildren Offset-Y baselineExtent error 6. text more max-size, hidden error 7. skia::text::measureTextInsideOneRun which use by TextPainer.layout(), jump the error
…ace-btween and flex main axis child margin set
1. fix flex and flow negative margin error 2. fix line join lineExtent not right 3. text line box line extent error 4. first more-line text with other text error 5. flowlayout inline render setChildren Offset-Y baselineExtent error 6. text more max-size, hidden error 7. skia::text::measureTextInsideOneRun which use by TextPainer.layout(), jump the error
…bf into feature/text-flow-sliver-css
looseyi
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.truncate {
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}
overflow not working, it will wrap onto a new line if content overflow
…w-sliver-css # Conflicts: # webf/lib/src/dom/element.dart # webf/lib/src/dom/event.dart # webf/lib/src/launcher/controller.dart # webf/lib/src/rendering/flow.dart # webf/lib/src/rendering/paragraph.dart # webf/lib/src/rendering/text.dart # webf/lib/src/rendering/text_control.dart # webf/lib/src/widget/webf.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.Feat: Text with other RenderBox layout in FlowLayout like web.
3.Feat: Support Sliver change direction.
4.Fix: Css Animation replay error.
5.Fix: Sliver element delete or insert error.