Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix use-of-free crash of shared string property in event object. #458

Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix: fix use-of-free crash of shared string property in event object. #458

merged 2 commits into from
Aug 15, 2023

Conversation

andycall
Copy link
Member

@andycall andycall commented Aug 13, 2023 •
edited
Loading

Fixed #456

looseyi
looseyi approved these changes Aug 13, 2023
View reviewed changes
Copy link
Contributor

@looseyi looseyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works

@andycall andycall added this pull request to the merge queue Aug 15, 2023
Merged via the queue into main with commit e4d2a53 Aug 15, 2023
@andycall andycall deleted the fix/event_shared_string_prop branch August 15, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devjiangzhou devjiangzhou devjiangzhou approved these changes

@looseyi looseyi looseyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash: pointer being freed was not allocated for webf::Event::item
3 participants
@andycall @devjiangzhou @looseyi