Fix repositioniong of the feedback popover when typing in MathQuill inputs. #1110

drgrice1 · 2024-09-01T23:06:37Z

When an answer has multiple responses and a MathQuill input for a response that is not the first one is typed in with a feedback popover open, the feedback popover does not correctly resposition. This is because currently only the first answer label is saved in the data attribute. So when the mqeditor sets up the later responses which have different answer labels, it doesn't see the feedback button. So now all answer labels for the response group are saved as a JSON encoded array. The mqeditor then searches the feedback buttons on the page to find the one with the correct answer label.

Here is a MWE for testing this:

DOCUMENT();
loadMacros('PGstandard.pl', 'PGML.pl');
Context('Matrix');
$A = Matrix([ [ 0, -1 ], [ 1, 0 ] ]);
BEGIN_PGML
Enter [`[$A]`]: [_]*{$A}{10}
END_PGML
ENDDOCUMENT();

If you type in a matrix entry other than the first column of the first row when a feedback popover is open, then the popover position is not updated with the develop branch, but is with this pull request.

Note that this also occurs with MultiAnswer objects with singleResult => 1 set.

Now, I was actually trying to fix @somiaj's comment in openwebwork/webwork2#2524 (comment). I believe that this might also fix that issue. I can't test that because I can't reproduce this issue (my computer is to fast?). However, I have good reason to believe that this will fix it.

drgrice1 · 2024-09-01T23:14:38Z

Actually, I have now been able to reproduce @somiaj's issue, and this does fix it.

somiaj

The issue would only happen some times, and only happens on my remote live server, not my local development server, so it felt like a timing issue. I am not able to reproduce the issue after applying this change, so it seems to fix it for me too.

@somiaj

…nputs. When an answer has multiple responses and a MathQuill input for a response that is not the first one is typed in with a feedback popover open, the feedback popover does not correctly resposition. This is because currently only the first answer label is saved in the data attribute. So when the mqeditor sets up the later responses which have different answer labels, it doesn't see the feedback button. So now all answer labels for the response group are saved as a JSON encoded array. The mqeditor then searches the feedback buttons on the page to find the one with the correct answer label. Here is a MWE for testing this: ```perl DOCUMENT(); loadMacros('PGstandard.pl', 'PGML.pl'); Context('Matrix'); $A = Matrix([ [ 0, -1 ], [ 1, 0 ] ]); BEGIN_PGML Enter [`[$A]`]: [_]*{$A}{10} END_PGML ENDDOCUMENT(); ``` If you type in a matrix entry other than the first column of the first row when a feedback popover is open, then the popover position is not updated with the develop branch, but is with this pull request. Note that this also occurs with `MultiAnswer` objects with `singleResult => 1` set. Now, I was actually trying to fix @somiaj's comment in openwebwork/webwork2#2524 (comment). I believe that this might also fix that issue. I can't test that because I can't reproduce this issue (my computer is to fast?). However, I have good reason to believe that this will fix it.

pstaabp · 2024-09-06T15:10:24Z

I don't see this happening, but this PR seems to still behave.

@drgrice1 I was looking at the code and I notice that on line 29 in mqeditor.js that refer to answerLabel. Does the change to answerLabels in PG.pl affect this as well?

drgrice1 · 2024-09-06T15:15:35Z

Only line 41 of mqeditor.js refers to the answerLabels in PG.pl. The other instance is a local variable.

drgrice1 · 2024-09-06T15:16:53Z

The local variable is defined on line 18 of mqeditor.js and that is what is used on line 29 (and many other places).

…ix-hotfix Fix repositioniong of the feedback popover when typing in MathQuill inputs. (hotfix of #1110)

somiaj · 2024-09-28T02:17:08Z

@drgrice1 Found another minor positing issue along these lines. Changing the height of a MathQuill input can affect positions of other input buttons, but only the popup of the input that changes is adjusted as a result. Here is a screenshot of the result.

drgrice1 · 2024-09-28T02:23:46Z

Hmm. I will see what I can do about that.

@somiaj

…povers. This fixes the issue reported by @somiaj in openwebwork#1110 (comment).

@somiaj