Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a local link in the package-lock.json file. #1148

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

drgrice1
Copy link
Member

This is a remnant from testing the recent MathQuill changes locally, that seems to have stayed there even after uninstalling the local link. This was never supposed to have been committed.

This is a remnant from testing the recent MathQuill changes locally,
that seems to have stayed there even after uninstalling the local link.
This was never supposed to have been committed.
Copy link
Contributor

@somiaj somiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just merge this, seems obvious we shouldn't be linking to stuff on your computer.

@somiaj somiaj merged commit d96332c into openwebwork:develop Nov 25, 2024
3 checks passed
@drgrice1
Copy link
Member Author

Yeah, that was a stupid mistake. I thought that when the link was uninstalled it would remove that, but it didn't. In fact, I found the only way to remove it was to manually delete it from the file. So I will need to remember to check that if I use a local link again.

@drgrice1 drgrice1 deleted the remove-package-lock-local-link branch November 25, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants