Prevent scaffolds from revealing correct answers when feedback is not permitted (really) #1163
Conversation
|
Note that as stated in #986, the main point of this is for tests. In homework, although the correct colors will not be shown on preview, there is still an indication of correctness that the savvy student can figure out (depending on the scaffold settings of the problem). That is that later scaffolds will open when previous parts are correct. For tests even that will not reveal that parts are correct since all scaffolds are forced open in tests to begin with. |
… permitted (really) In openwebwork#986 I believed that this was set. But either something has changed since then, or I didn't have it right at that point. In that pull request I claimed that when an answer preview occurs, scaffolds will open but not receive the green color if all answers within are correct. In particular, if a preview occurs it should not reveal that answers are correct. Unfortunately, it still is. This fixes that by only giving the correct colors when attempt results are allowed.
drgrice1
force-pushed
the
scaffolds-no-reveal-correct-really
branch
from
eeda98b to
4aee938
Compare
There was a problem hiding this comment.
Works as described.
I'll close #1105 when this is merged, as I didn't realize that the correct color wasn't suppose to be shown which is part of what that issue was about. Sure a clever student who realizes the state of the scaffolds in homework can still use preview to figure out correct answers, but this is no longer possible in tests with my testing.
I'd suggest a hotfix for this as it is small and probably worthwhile to have in 2.19 for the time.
|
I would agree to a hot fix since this was supposed to be something new for 2.19. |
In #986 I believed that this was set. But either something has changed since then, or I didn't have it right at that point.
In that pull request I claimed that when an answer preview occurs, scaffolds will open but not receive the green color if all answers within are correct. In particular, if a preview occurs it should not reveal that answers are correct. Unfortunately, it still is.
This fixes that by only giving the correct colors when attempt results are allowed.