Prevent scaffolds from revealing correct answers when feedback is not permitted (really) - hotfix #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… permitted (really) In openwebwork#986 I believed that this was set. But either something has changed since then, or I didn't have it right at that point. In that pull request I claimed that when an answer preview occurs, scaffolds will open but not receive the green color if all answers within are correct. In particular, if a preview occurs it should not reveal that answers are correct. Unfortunately, it still is. This fixes that by only giving the correct colors when attempt results are allowed.
somiaj
approved these changes
Dec 14, 2024
Alex-Jordan
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #986 I believed that this was set. But either something has changed since then, or I didn't have it right at that point.
In that pull request I claimed that when an answer preview occurs, scaffolds will open but not receive the green color if all answers within are correct. In particular, if a preview occurs it should not reveal that answers are correct. Unfortunately, it still is.
This fixes that by only giving the correct colors when attempt results are allowed.