[feature] Added support for Ubuntu 20.04 (#189) #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloCastellano
force-pushed
the
issue/189-add-support-ubuntu2004
branch
from
b2b664c to
e8f6025
Compare
- switched to use /usr/bin/python3 by default - python-virtualenv > python3-virtualenv - build in travis using ubuntu 20.04 - add ubuntu 20.04 (focal) to meta info - handle redis 4/5 and dependencies - removed step to install python-wheel (installed by pip later) - simplified python3-virtualenv installation - pin channels_redis to 2.4 for redis 4 compatibility Closes #189
PabloCastellano
force-pushed
the
issue/189-add-support-ubuntu2004
branch
from
e8f6025 to
30c1c34
Compare
nemesifier
reviewed
Sep 17, 2020
files/generate_django_secret_key.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env python | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
are you sure this is needed? The virtualenv should know the python version without the need of introducing this change
There was a problem hiding this comment.
Not sure now, but I probably made this change and then forgot to remove it 😁
|
@PabloCastellano the type should be feature instead of feat |
More info about that here: openwisp/openwisp-utils#110 (comment) |
nemesifier
force-pushed
the
issue/189-add-support-ubuntu2004
branch
from
02755e3 to
26654f0
Compare
nemesifier
approved these changes
Sep 19, 2020
nemesifier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this PR integrates the work done in #190)
Closes #189