-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] REST API can creates device configs inadvertently #699
Labels
Comments
pandafy
added a commit
that referenced
this issue
May 4, 2023
pandafy
added a commit
that referenced
this issue
May 4, 2023
pandafy
added a commit
that referenced
this issue
May 4, 2023
pandafy
added a commit
that referenced
this issue
May 4, 2023
pandafy
added a commit
that referenced
this issue
May 8, 2023
pandafy
added a commit
that referenced
this issue
May 15, 2023
nemesifier
pushed a commit
that referenced
this issue
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a follow up of #697 (review).
Create a device with no related configuration.
Open the REST API endpoint to change the device details, eg:
http://localhost:8000/api/v1/controller/device/{pk}/
Now, hit the PUT button without changing anything.
Expected result:
Actual result:
If I reset the repository state to before #697, an exception is raised.
After merging #697 the exception is not raised anymore and the config is created.
Ideally we shouldn't create/change the config unless anything in the config object is added/changed.
The text was updated successfully, but these errors were encountered: