Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Sometimes command response is not shown #772

Closed
nemesifier opened this issue May 31, 2023 · 1 comment · Fixed by #773
Closed

[bug] Sometimes command response is not shown #772

nemesifier opened this issue May 31, 2023 · 1 comment · Fixed by #773
Assignees
Labels

Comments

@nemesifier
Copy link
Member

When sending commands, in some cases the response is not shown.
This happens when there's already some recent commands in the UI and the UI relies on the websocket communication.

@pandafy please help me to replicate and fix this bug, I suspect the initial websocket connection can fail to establish, if this is the cause, we can change the code to retry to establish the connection until it works.

@pandafy
Copy link
Member

pandafy commented Jun 1, 2023

In my testing, I found that this issue appears on slow internet connection.

Steps to replicate:

  1. Open change page for any device
  2. Open web debugger tools, and set network throttling to slow 3G
  3. Refresh the page
  4. Filter the websocket connections

You will see that the websocket connection is not getting established.

I believe the culprit is the tiimeoutInterval setting of ReconnectingWebSocket.

Updating the timeoutInterval to 5000 fixed the issue locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants