-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add geojson endpoints #360 #374
[feature] Add geojson endpoints #360 #374
Conversation
This comment has been minimized.
This comment has been minimized.
a6f6b95
to
5a22e0d
Compare
5a22e0d
to
a41a5fd
Compare
1e75dca
to
e841656
Compare
31ea6a7
to
74553b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress @purhan!
I tried opening the geojson URL without being logged in and got this exception:
'AnonymousUser' object has no attribute 'organizations_managed'
Is this a problem of these views or is it an underlying issue of the filtering classes in openwisp-users?
Ensure the views are accessible only to authenticated users.
The rest looks good but I will spend some more time testing it, see also my comment below.
@nemesisdesign I've fixed it by adding a permission class to allow only the authenticated users to access it. I think we should add this functionality in the filter classes themselves. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress @purhan!
I tried opening the geojson URL without being logged in and got this exception:'AnonymousUser' object has no attribute 'organizations_managed'
Is this a problem of these views or is it an underlying issue of the filtering classes in openwisp-users?
Ensure the views are accessible only to authenticated users.
The rest looks good but I will spend some more time testing it, see also my comment below.@nemesisdesign I've fixed it by adding a permission class to allow only the authenticated users to access it. I think we should add this functionality in the filter classes themselves. What do you think?
Yes I think you're right @purhan.
One more request, I forgot to mention it before, can you add a brief mention of this endpoint in the README? https://github.com/openwisp/openwisp-controller#geo-app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the rest looks good!
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @purhan 👍!
Closes #360