Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] No valid IP addresses to initiate connections found #235

Closed
nemesifier opened this issue May 30, 2023 · 0 comments · Fixed by #236
Closed

[bug] No valid IP addresses to initiate connections found #235

nemesifier opened this issue May 30, 2023 · 0 comments · Fixed by #236
Labels
bug Something isn't working

Comments

@nemesifier
Copy link
Member

Recent versions of OpenWISP Controller can raise a ValueError exception which is not caught by this module.
When this happens, instead of continuing to retry, the retry mechanism stops, eg:

Trying to reconnect to device at 172.16.0.32 (attempt n.5)...
Device not reachable yet, (timed out).
retrying in 20 seconds...
Trying to reconnect to device at (attempt n.6)...
No valid IP addresses to initiate connections found

This looks like a bug. The system must keep retrying until the max amount of retries are reached, in that case the last line of the log would look different.

@nemesifier nemesifier added the bug Something isn't working label May 30, 2023
nemesifier added a commit that referenced this issue May 30, 2023
The test is misssing.

Fixes #235
nemesifier added a commit that referenced this issue May 30, 2023
The test is misssing.

Fixes #235
nemesifier added a commit that referenced this issue Jun 1, 2023
The test is misssing.

Fixes #235
nemesifier added a commit that referenced this issue Jun 1, 2023
The test is misssing.

Fixes #235
pandafy pushed a commit that referenced this issue Jun 7, 2023
The test is misssing.

Fixes #235
nemesifier added a commit that referenced this issue Jun 9, 2023


Fixes #235

Co-authored-by: Gagan Deep <pandafy.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
1 participant