-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Added support for device deactivation #560 #607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens to the monitoring status of a device when it gets deactivated?
I was expecting to see some logic which would see some logic for the following:
- Making sure monitoring checks are not run
- Setting monitoring status to "UNKNOWN". Or, we can use a special status for this e,g, "DEACTIVATED" - I think "DEACTIVATED" is more explicit and preferable for UX
- Replying with 404 for monitoring requests
I would also add that activating a device must reverse this: checks are run again, hence monitoring status should automatically become either OK or CRITICAL and device metrics shall be accepted.
We need tu update the docs to reflect these changes.
Please rebase on the latest master and reformat code if necessary.
fd72d0e
to
440d04c
Compare
8c668ae
to
833656a
Compare
833656a
to
b584a40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Color
Let's make the color of deactivate status black (#000
), both in the health status (which is now of the same color of unknown
) and in the pie chart:
Device details: hide checks
Once the device is deactivated, I think we shouldn't show the checks in the device details anymore:
Cache invalidation
Let's ensure that once the device is deactivated, the monitoring API responds 404 correctly, during testing we noticed a cache invalidation issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
311f645
to
c821a2f
Compare
8dc6d57
to
c6927eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During testing, I noticed that reactivating a device leaves the health status as "DEACTIVATED", I think we should change this, the only option we have is "UNKNOWN" unless we add a new one, but I think "UNKNOWN" is good for now, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update this docs page:
https://openwisp.io/docs/dev/monitoring/user/device-health-status.html
To mention the new health status.
1c0a320
to
4a6bfbf
Compare
4a6bfbf
to
3dca67f
Compare
Closes #560
Blockers