[fix] Use "time" argument for calculating time in "Chart._get_time" #612 #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
commented
Nov 6, 2024
| @@ -729,7 +729,7 @@ def _get_time(cls, time, start_date=None, end_date=None): | |||
| return start_date | |||
| if not isinstance(time, str): | |||
| return str(time) | |||
| if time in cls._get_group_map().keys(): | |||
| if time in cls._get_group_map(time).keys(): | |||
There was a problem hiding this comment.
The _get_time method handles time ranges like 1d, 7d, 30d, and 365d, returning the start date in string format for InfluxDB queries (e.g., time >= '2024-10-15').
The issue arose because the test used 5d, which was not in Chart.GROUP_MAP, causing the method to return 5d instead of a valid date, making the InfluxDB query invalid.
Passing the time argument to Chart._get_group_map, which can create custom group intervals, resolved the bug.
nemesifier
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Fixes #612