[tests] Update TestMultitenantAdminMixin to use default operator group

[nemesifier]

In this test utility code (which is reused across openwisp modules):

openwisp-users/openwisp_users/tests/utils.py

Lines 23 to 39 in cf5cd64

	operator_permission_filters = []
	def get_operator_permissions(self):
	filters = Q()
	for filter in self.operator_permission_filters:
	filters = filters | Q(**filter)
	return Permission.objects.filter(filters)
	def _create_operator(self, organizations=[]):
	operator = user_model.objects.create_user(username='operator',
	password='tester',
	email='operator@test.com',
	is_staff=True)
	operator.user_permissions.add(*self.get_operator_permissions())
	for organization in organizations:
	OrganizationUser.objects.create(user=operator, organization=organization)
	return operator

The test expects the permission of the operator to be defined as a class attribute.

This is obsolete, because in more recent versions of OpenWISP we added two default auth.Group instances: operator and administrator.

• update the test method to assign those groups
• remove operator_permission_filters = []
• remove get_operator_permissions

Open a pull request in each openwisp module to remove the operator_permission_filters and ensuring the new code works: https://github.com/search?q=org%3Aopenwisp+operator_permission_filters&type=Code

[niteshsinha17]

I am working on this Issue 😊

[niteshsinha17]

I think I need some more time to work on this Issue. If someone wants to work on it can go ahead.

[lehone-hp]

I will be working on this.

[lehone-hp]

@nemesisdesign after removing get_operator_permissions and assigning the Administrator and Operator permissions, several tests keep failing with the output below.

Please how do I proceed from here?

[niteshsinha17]

@lehone-hp This is happening because Operation does not have permission to access those pages that's why it is giving error Couldn't retrieve content. We may need to add permissions to the operator for it. Am I right @nemesisdesign ?

[niteshsinha17]

If you will remove these lines then it will not show any error.

openwisp-users/openwisp_users/tests/utils.py

Lines 85 to 98 in 8a411dd

	# ensure elements in visible list are visible to operator
	for el in visible:
	with self.subTest(el):
	self.assertContains(
	response, _f(el, select_widget), msg_prefix='[operator contains]'
	)
	# ensure elements in hidden list are not visible to operator
	for el in hidden:
	with self.subTest(el):
	self.assertNotContains(
	response,
	_f(el, select_widget),
	msg_prefix='[operator not-contains]',
	)

But I don't think it's a solution. nemesisdesign can give a better solution for it.

[nemesifier]

@lehone-hp This is happening because Operation does not have permission to access those pages that's why it is giving error Couldn't retrieve content. We may need to add permissions to the operator for it. Am I right @nemesisdesign ?

I think this is correct.

[lehone-hp]

Okay, I will assign the appropriate permissions and then open a PR