Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Add a human readable value for empty org selection #171

Closed
nemesifier opened this issue Aug 23, 2020 · 4 comments · Fixed by #209
Closed

[admin] Add a human readable value for empty org selection #171

nemesifier opened this issue Aug 23, 2020 · 4 comments · Fixed by #209
Labels
enhancement Hacktoberfest Easy issues for attracting Hacktoberfest participants.

Comments

@nemesifier
Copy link
Member

When the organization selection is optional, it means that leaving it empty makes that object available for all the organizations in the system.

Right now, this is not intuitive at all. We could use some admin form magic to replace the empty string with something like: Shared systemwide (no organization).

@nemesifier nemesifier added the Hacktoberfest Easy issues for attracting Hacktoberfest participants. label Sep 24, 2020
@devkapilbansal devkapilbansal self-assigned this Dec 25, 2020
@devkapilbansal
Copy link
Member

When the organization selection is optional, it means that leaving it empty makes that object available for all the organizations in the system.

Right now, this is not intuitive at all. We could use some admin form magic to replace the empty string with something like: Shared systemwide (no organization).

@nemesisdesign I setup the project locally by following instructions. But I don't think that the organisation selection is optional. Can you please look into this again and elaborate the issue?

@purhan
Copy link
Contributor

purhan commented Dec 27, 2020

When the organization selection is optional, it means that leaving it empty makes that object available for all the organizations in the system.
Right now, this is not intuitive at all. We could use some admin form magic to replace the empty string with something like: Shared systemwide (no organization).

@nemesisdesign I setup the project locally by following instructions. But I don't think that the organisation selection is optional. Can you please look into this again and elaborate the issue?

@devkapilbansal I've been working on this issue and I'm pretty close to a patch 😄 however, I didn't claim this so that's on my part. Would you like to leave this? For your question, yes, the sample app we're using currently has 2 models: Book and Shelf, and these both have mandatory (i.e not optional) organization field.

@devkapilbansal
Copy link
Member

Okay @purhan you can take this up. But if the organisation field is not optional, then does this issue makes sense?

@purhan
Copy link
Contributor

purhan commented Dec 27, 2020

Okay @purhan you can take this up. But if the organisation field is not optional, then does this issue makes sense?

Yes, because there may be other modules relying on openwisp-users where some models have it optional.

@devkapilbansal devkapilbansal removed their assignment Dec 27, 2020
purhan added a commit to purhan/openwisp-users that referenced this issue Dec 28, 2020
nemesifier added a commit that referenced this issue Dec 30, 2020
Closes #171

Co-authored-by: Federico Capoano <federico.capoano@gmail.com>
@nemesifier nemesifier moved this to Done in Roadmap Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Hacktoberfest Easy issues for attracting Hacktoberfest participants.
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants