Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Added support for django 3.2 and 4.0 alpha #255 #258

Merged
merged 4 commits into from
Oct 15, 2021

Conversation

codesankalp
Copy link
Member

Changes

Fixed all the tests and issues related to django 3.2 and 4.0 alpha.

Checklist

  • I have read the contributing guidelines.
  • I have manually tested the proposed changes.
  • I have written new test cases to avoid regressions. (if necessary)
  • I have updated the documentation. (e.g. README.rst)
  • I have added [change!] to commit title to indicate a backward incompatible change. (if required)
  • I have checked the links added / modified in the documentation.

Closes #255

Fixed all the tests and issues related to django 3.2 and 4.0 alpha.

Closes #255
@codesankalp
Copy link
Member Author

I tested locally for python==3.7 and django=4.0a1, it is working fine. But in CI the Django alpha version is not present while installing: https://github.com/openwisp/openwisp-utils/pull/258/checks?check_run_id=3893636475#step:6:121

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems Django 4 is not compatible with python 3.7, so we should avoid running tests with Django 4 and python 3.7:
https://docs.djangoproject.com/en/dev/releases/4.0/

tests/test_project/tests/test_storage.py Show resolved Hide resolved
tests/test_project/apps.py Show resolved Hide resolved
tests/test_project/tests/test_test_utils.py Outdated Show resolved Hide resolved
@codesankalp codesankalp force-pushed the issue-255-django-version-support branch 3 times, most recently from d03b9ab to 990536f Compare October 14, 2021 18:14
@codesankalp codesankalp force-pushed the issue-255-django-version-support branch from 990536f to 0005c34 Compare October 14, 2021 18:17
@coveralls
Copy link

coveralls commented Oct 14, 2021

Coverage Status

Coverage remained the same at 98.431% when pulling 4fd3110 on issue-255-django-version-support into 9e182fd on master.

- django~=3.0.0
- django~=3.1.0
- django~=3.2.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 3.2.0 for consisntency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were bug in 3.2.0, so I thought to use 3.2.8: https://docs.djangoproject.com/en/3.2/releases/3.2.8/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codesankalp there's always bugs in the initial minor versions of a release, the build will install the latest available version anyway. It's a matter of clarify, readability and consistency. By indicating ~=3.2.0 we know the build will use the latest 3.2.x version.

tests/test_project/tests/test_test_utils.py Outdated Show resolved Hide resolved
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works, thanks! A couple minor improvements requested below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[deps] Add support for django 3.2 and django 4.0 alpha
3 participants