-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deps] Added support for django 3.2 and 4.0 alpha #255 #258
Conversation
Fixed all the tests and issues related to django 3.2 and 4.0 alpha. Closes #255
I tested locally for python==3.7 and django=4.0a1, it is working fine. But in CI the Django alpha version is not present while installing: https://github.com/openwisp/openwisp-utils/pull/258/checks?check_run_id=3893636475#step:6:121 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems Django 4 is not compatible with python 3.7, so we should avoid running tests with Django 4 and python 3.7:
https://docs.djangoproject.com/en/dev/releases/4.0/
d03b9ab
to
990536f
Compare
990536f
to
0005c34
Compare
.github/workflows/ci.yml
Outdated
- django~=3.0.0 | ||
- django~=3.1.0 | ||
- django~=3.2.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be 3.2.0
for consisntency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were bug in 3.2.0, so I thought to use 3.2.8: https://docs.djangoproject.com/en/3.2/releases/3.2.8/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codesankalp there's always bugs in the initial minor versions of a release, the build will install the latest available version anyway. It's a matter of clarify, readability and consistency. By indicating ~=3.2.0 we know the build will use the latest 3.2.x version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works, thanks! A couple minor improvements requested below.
Changes
Fixed all the tests and issues related to django 3.2 and 4.0 alpha.
Checklist
Closes #255