[WIP] Move dns_instrument from onCompleted to onHeadersReceived #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1021 +/- ##
=======================================
Coverage 45.74% 45.74%
=======================================
Files 35 35
Lines 3478 3478
=======================================
Hits 1591 1591
Misses 1887 1887 ☔ View full report in Codecov by Sentry. |
|
Good Catch! Does this also resolve the issue where DNS requests for domains that don't resolved aren't captured? |
|
I'm not sure. I'll need to write a test page for both of these conditions. |
vringar
force-pushed
the
dns_instrument_fix
branch
from
159c5fa
to
628e3f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1020 WIP. I haven't tested this much.