Added scripts to set PYTHONUSERSITE #726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also puts in place a more general infrastructure should we ever become more opinionated and automatically hook up things like pre-commit
|
I don't get this, we already set PYTHONUSERSITE where it's needed to solve the issue: https://github.com/mozilla/OpenWPM/blob/master/scripts/repin.sh#L12-L15 Why is the existing solution insufficient? |
|
I've just seen the tread on matrix so am caught up on your motivations. |
birdsarah
reviewed
Aug 31, 2020
| This script aims to be plattform independent and idempotent | ||
| """ | ||
|
|
||
| CONDA_SCRIPT_DIR = "./etc/conda" |
There was a problem hiding this comment.
I still have a path in my head of how we can support windows. I think it would be good if we didn't add things that inhibit that possibility.
|
Yeah, this PR is pretty broken. Do you want to pick it up and play around with it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also puts in place a more general infrastructure
should we ever become more opinionated and
automatically hook up things like pre-commit
Closes #689