Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phase1: workaround gitverify 1st build failures on fresh workers #6

Merged
merged 1 commit into from
May 17, 2023

Conversation

ynezz
Copy link
Member

@ynezz ynezz commented May 16, 2023

Currently every 1st build on ephemeral build worker results in the failure of the gitverify build step as the stock buildbot Git() build step for some reasons just clones the Git repository into detached HEAD state.

On the 2nd build using the same build worker Git() checkouts the branch and thus makes gitverify step happy and the builds then continues normally.

This needs to be fixed properly, either by adjusting the gitverify check or adding suitable mode into Git() build step, but this needs more time and testing.

So for now, lets simply workaround that issue by running Git() step two times.

References: #5

Currently every 1st build on ephemeral build worker results in the
failure of the `gitverify` build step as the stock buildbot Git() build
step for some reasons just clones the Git repository into detached HEAD
state.

On the 2nd build using the same build worker Git() checkouts the branch
and thus makes `gitverify` step happy and the builds then continues
normally.

This needs to be fixed properly, either by adjusting the `gitverify`
check or adding suitable `mode` into Git() build step, but this needs
more time and testing.

So for now, lets simply workaround that issue by running Git() step two
times.

References: #5
Signed-off-by: Petr Štetiar <ynezz@true.cz>
@ynezz ynezz merged commit d47fd60 into openwrt:master May 17, 2023
@ynezz ynezz deleted the ynezz/workaround-gitverify-failures branch July 22, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant