Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-mod-network: disabling vlan_naming has no effect #7640

Open
1 task done
emi-YFcz5XDj opened this issue Feb 20, 2025 · 1 comment · May be fixed by openwrt/openwrt#18053
Open
1 task done

luci-mod-network: disabling vlan_naming has no effect #7640

emi-YFcz5XDj opened this issue Feb 20, 2025 · 1 comment · May be fixed by openwrt/openwrt#18053

Comments

@emi-YFcz5XDj
Copy link

emi-YFcz5XDj commented Feb 20, 2025

Is there an existing issue for this?

  • I have searched among all existing issues (including closed issues)

screenshots or captures

Image

Actual behaviour

Disabling vlan_naming in LuCI causes it to delete the option.

However, hostapd.sh defaults to 1 when the option isn't present.

Disabling it in LuCI therefore has no effect.

Expected behaviour

When vlan_naming is disabled in LuCI, wifi-scripts should write vlan_naming=0 into hostapd.conf.

Steps to reproduce

  1. Set up WPA2/3 Enterprise Wi-Fi
  2. Untick "RADIUS VLAN Naming", and save
  3. Preview uci changes, and apply
  4. Run cat /var/hostapd-*.conf | less in ssh
  5. Observe the issue

Additional Information

{
	"kernel": "6.6.73",
	"hostname": "openwrt",
	"system": "ARMv8 Processor rev 4",
	"model": "GL.iNet GL-MT6000",
	"board_name": "glinet,gl-mt6000",
	"rootfs_type": "squashfs",
	"release": {
		"distribution": "OpenWrt",
		"version": "24.10.0",
		"revision": "r28427-6df0e3d02a",
		"target": "mediatek/filogic",
		"description": "OpenWrt 24.10.0 r28427-6df0e3d02a"
	}
}

What browsers do you see the problem on?

No response

Relevant log output

@systemcrash
Copy link
Contributor

Would you like to try to make a PR?

emi-YFcz5XDj added a commit to emi-YFcz5XDj/openwrt that referenced this issue Feb 21, 2025
LuCI removes vlan_naming when it's disabled, but
hostapd.sh defaults to 1 when vlan_naming is absent.

Disabling vlan_naming in LuCI therefore has no effect.

This commit fixes this issue by changing the default to 0.

Fixes: openwrt/luci#7640
Signed-off-by: Alice H. <161944892+emi-YFcz5XDj@users.noreply.github.com>
emi-YFcz5XDj added a commit to emi-YFcz5XDj/openwrt that referenced this issue Feb 21, 2025
LuCI removes vlan_naming when disabled, but hostapd.sh
defaults to 1 when vlan_naming is absent.

Disabling vlan_naming in LuCI therefore has no effect.

This commit resolves the issue by changing the default to 0.

Fixes: openwrt/luci#7640
Signed-off-by: Alice H. <161944892+emi-YFcz5XDj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants