luci-app-ser2net: created #1480
Conversation
Signed-off-by: Jasper Scholte <NightNL@outlook.com>
TimelessNL
changed the title
| @@ -0,0 +1,14 @@ | |||
| # | |||
| # Copyright (C) 2008-2017 The LuCI Team <luci@lists.subsignal.org> | |||
There was a problem hiding this comment.
As I know please change the Copyright notice to
Copyright (C) 2018 Jasper Scholte NightNL@outlook.com
| @@ -0,0 +1,7 @@ | |||
| module("luci.controller.ser2net", package.seeall) | |||
There was a problem hiding this comment.
Could you please add the following header on top off the file
-- Copyright (C) 2018 Jasper Scholte NightNL@outlook.com
-- Licensed to the public under the Apache License 2.0.
| @@ -0,0 +1,58 @@ | |||
| m = Map("ser2net", translate("ser2net"), | |||
There was a problem hiding this comment.
Could you please add the following header on top off the file
-- Copyright (C) 2018 Jasper Scholte NightNL@outlook.com
-- Licensed to the public under the Apache License 2.0.
| translate("The ser2net allows telnet and tcp sessions to be established with a unit's serial ports.<br/>")) | ||
|
|
||
| function m.on_after_commit(self) | ||
| luci.sys.call("/etc/init.d/ser2net enable 1\>/dev/null 2\>/dev/null") |
There was a problem hiding this comment.
You could use
luci.sys.init.enable("ser2net")
|
|
||
| function m.on_after_commit(self) | ||
| luci.sys.call("/etc/init.d/ser2net enable 1\>/dev/null 2\>/dev/null") | ||
| luci.sys.call("/etc/init.d/ser2net restart 1\>/dev/null 2\>/dev/null") |
There was a problem hiding this comment.
You sould use
luci.sys.call("/etc/init.d/ser2net restart >/dev/null 2>&1")
|
Changes you submitted seem to write to configuration that only luci understands. In my opinion it seems unreliable, because:
|
|
True. I forgot about this request. The implementation has changed in OpenWrt. So I have to refactor this pullrequest. I'll close it for now. |
This changeset will add support for ser2net in luci-app-ser2net.
Note: This depends on openwrt/packages#5302 to be accepted first.
Note2: This changeset is based on https://github.com/JiapengLi/OpenWrt-luci-app-ser2net/blob/master/openwrt-packages-add-luci-app-ser2net-support.patch