Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: make rpcd scripts executable #7527

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

dannil
Copy link
Contributor

@dannil dannil commented Jan 5, 2025

The git index needs the executable permission on RPC scripts to correctly register them with ubus.

Link: #7526

  • This PR is not from my main or master branch πŸ’©, but a separate branch βœ…
  • Each commit has a valid βœ’οΈ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid πŸ“ <package name>: title first line subject for packages
  • Incremented πŸ†™ any PKG_VERSION in the Makefile N/A
  • Tested on: (x86/64, 24.10.0-rc4, Firefox) βœ…
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: (describe the changes proposed in this PR)

@dannil
Copy link
Contributor Author

dannil commented Jan 5, 2025

If this gets merged it should also be cherry-picked to the 24.10 branch.

The git index needs the executable permission on RPC scripts to correctly
register them with ubus.

Link: openwrt#7526

Signed-off-by: Daniel Nilsson <dannil+github@protonmail.com>
@systemcrash systemcrash merged commit 36c01da into openwrt:master Jan 5, 2025
3 checks passed
@systemcrash
Copy link
Contributor

Merged. Thanks @dannil !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants