Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-base: expose static IPv6 configuration even if IPv6-PD is enabled. #7556

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

adelton
Copy link
Contributor

@adelton adelton commented Jan 10, 2025

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: x86_64 VM with OpenWrt 24.10.0-rc5 (r28304-6dacba30a7)
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes Interface IPv6 configuration: PD and static IPv6 address #3340
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: expose static IPv6 configuration even if IPv6-PD is enabled.

Signed-off-by: Jan Pazdziora <jan.pazdziora@code.adelton.com>
@adelton adelton changed the title Draft: luci-base: expose static IPv6 configuration even if IPv6-PD is enabled. luci-base: expose static IPv6 configuration even if IPv6-PD is enabled. Jan 10, 2025
@adelton
Copy link
Contributor Author

adelton commented Jan 10, 2025

I had to move this PR one commit back in the master branch, to avoid the issue being addressed by #7557.

@Ramon00
Copy link
Contributor

Ramon00 commented Jan 11, 2025

Would this not make it confusing for most people? I.e. nowhere is it now shown that this is optional if you have IPv6-PD?

@adelton
Copy link
Contributor Author

adelton commented Jan 11, 2025

Well the values are optional since they are not mandatory. :-)

What is your suggestion? Do you think we should add some explicit hints about these being optional and "possibly not needed" when IPv6-PD is enabled? Or?

@Ramon00
Copy link
Contributor

Ramon00 commented Jan 11, 2025

yeah maybe add to the hint "optional if IPv6-PD enabled". Alternative would be add an extra toggle "enable manual IPv6" which only shows up if you have IPv6-PD and which unhides the additional 3 items?

@systemcrash systemcrash merged commit 8ae0008 into openwrt:master Jan 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants