luci-app-attendedsysupgrade: sort latest version array #7579
Conversation
The Attended Sysupgrade app requires that the array of latest versions be in order from newest release to oldest. Ensure that this is true even when upstream presents them in arbitrary order. Signed-off-by: Eric Fahlgren <ericfahlgren@gmail.com>
|
Should be backported to 24.10. |
|
I think this isn't the best solution, it requires clients to update packages before a firmware upgrade. We should always avoid that |
And that's because of a list sort? |
Likely aparcar means that is does not yet benefit those who are trying to upgrade from versions before this patch. But this will help in future when later upgrading from versions with this patch. |
|
Plus Paul has merged a change to the ASU server, too, so we're fixing the issue in two ways: ASU server sorts according to the LuCI app's preference (handles 23.05 and earlier app users); and with this the PR LuCI app is robust in the presence of unsorted data (handles any changes we might make to ASU server in the future). |
|
Sorry, I read "update packages" as "update all packages" instead of "update this package". |
The Attended Sysupgrade app requires that the array of latest versions be in order from newest release to oldest. Ensure that this is true even when upstream presents them in arbitrary order.