script: don't ignore RA with zero router lifetime #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per RFC 4861 (section 4.2), 0 is a valid value for Router Lifetime field in Router Advertisement messages. To quote from the RFC: > A Lifetime of 0 indicates that the router is not a > default router and SHOULD NOT appear on the default > router list. In fact, this is the mechanism by which a router, previously advertising itself as a default router must invalidate itself. From the RFC 7084 (4.1, G-5): > By default, if the IPv6 CE router is an advertising > router and loses its IPv6 default router(s) and/or > detects loss of connectivity on the WAN interface, > it MUST explicitly invalidate itself as an IPv6 > default router on each of its advertising interfaces > by immediately transmitting one or more Router > Advertisement messages with the "Router Lifetime" > field set to zero [RFC4861]. Given that Router Lifetime is stored in the `valid` field of the `struct odhcp6c_entry`, entries with the field set to 0 shouldn't be ignored when entry type is `ENTRY_ROUTE`. Signed-off-by: Gasper Stukelj <gstukelj@plume.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per RFC 4861 (section 4.2), 0 is a valid value for Router Lifetime field in Router Advertisement messages. To quote from the RFC:
In fact, this is the mechanism by which a router, previously advertising itself as a default router must invalidate itself. From the RFC 7084 (4.1, G-5):
Given that Router Lifetime is stored in the
validfield of thestruct odhcp6c_entry, entries with the field set to 0 shouldn't be ignored when entry type isENTRY_ROUTE.