mwan3: close flock fd when starting mwan3.user scripts

[feckert]

Maintainer: me
Compile tested: no
Run tested: no

Description:
Fixes deadlock with multiple init script calls.
Fixes openwrt/openwrt#15994

[BKPepe]

Anything new about this one? :)

[feckert]

@BKPepe Thanks for the hint. This is only a workaround .
The entire locking in mwan3 must be changed! See the comments.
Unfortunately I don't have the time now to fix it correctly for the upcoming release. So I think we should use the workaround fix.

[BKPepe]

It is missing bump in PKG_RELEASE, in such cases, I miss autorelease variable, which we have in past. :-( Yeah, I looked at the issue in the main repo, and for me, it seems like, we need to backport this fix to the stable releases because no one will rewrite the entire mwan3 in the foreseeable future, though.

[feckert]

@BKPepe Done with commit 0532015

[BKPepe]

Great, thanks!

[feckert]

@BKPepe The question now is. Should I backport all changes between master and owrt-23.05?
Otherwise my version numbering will no longer fit and I'll get mixed up!

[BKPepe]

What? Why you would do that in the first place?

In the master branch, there is version 2.11.16 and in the OpenWrt 23.05 branch, there is 2.11.8.
You will increase there only PKG_RELEASE and backport this small workaround and you suggested to backport all those changes? Hmm, this is not how this should work. :-)

[BKPepe]

Backports are done in the standard approach how they should be: 18c3e8d (OpenWrt 23.05). That's why there is cherry pick and this method is done here multiple times while backporting smth to stable releases.

[feckert]

Ok thanks for my feedback. I would have seen it the same way. I was just unsure, so I wanted to ask again.