Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libedit: update to version 20240808-3.1 #24770

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Conversation

Payne-X6
Copy link
Contributor

@Payne-X6 Payne-X6 commented Aug 12, 2024

Maintainer: Daniel Salzman / @salzmdan

Description:

  • update of the library on which knot depends on
  • package download protocol has been changed from HTTP to HTTPS
  • updated package version format to be compatible with the apk

Signed-off-by: Jan Hák <jan.hak@nic.cz>
libs/libedit/Makefile Outdated Show resolved Hide resolved
Signed-off-by: Jan Hák <jan.hak@nic.cz>
@@ -8,15 +8,15 @@
include $(TOPDIR)/rules.mk

PKG_NAME:=libedit
PKG_VERSION:=20240517-3.1
PKG_VERSION:=20240808-3.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it. Can you also fix the problem with the apk version migration?
#23706 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the change will have to be to 3.1-r20240808.
Do you know how it is with version comparisons? Because the opkg apparently considers the new version number older than the original (see opkg compare-versions 20240808-3.1 '<' 3.1-r20240808 returns false)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that sorry

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are multiple options:

  • Inform users about this and that they should do a manual "downgrade" (really upgrade)
  • Let them use auc or owut for an upgrade, the sys upgrade tools will inform the user about the package downgrade but the user likely understand the situation.
  • Set the version to 20240808.3.1 which should be compatible with both

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the version to 20240808.3.1

That would then require additional Makefile variables, as the version in the original format is part of the upstream filename.

We might have an APK related wikipage with helpful hints about solutions to that kind of needs. And the new CI message might link to that page.

Signed-off-by: Jan Hák <jan.hak@nic.cz>
@neheb neheb merged commit 32dec92 into openwrt:master Aug 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants