-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libedit: update to version 20240808-3.1 #24770
Conversation
Signed-off-by: Jan Hák <jan.hak@nic.cz>
Signed-off-by: Jan Hák <jan.hak@nic.cz>
libs/libedit/Makefile
Outdated
@@ -8,15 +8,15 @@ | |||
include $(TOPDIR)/rules.mk | |||
|
|||
PKG_NAME:=libedit | |||
PKG_VERSION:=20240517-3.1 | |||
PKG_VERSION:=20240808-3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're at it. Can you also fix the problem with the apk version migration?
#23706 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the change will have to be to 3.1-r20240808
.
Do you know how it is with version comparisons? Because the opkg apparently considers the new version number older than the original (see opkg compare-versions 20240808-3.1 '<' 3.1-r20240808
returns false
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about that sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are multiple options:
- Inform users about this and that they should do a manual "downgrade" (really upgrade)
- Let them use
auc
orowut
for an upgrade, the sys upgrade tools will inform the user about the package downgrade but the user likely understand the situation. - Set the version to
20240808.3.1
which should be compatible with both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set the version to 20240808.3.1
That would then require additional Makefile variables, as the version in the original format is part of the upstream filename.
We might have an APK related wikipage with helpful hints about solutions to that kind of needs. And the new CI message might link to that page.
Signed-off-by: Jan Hák <jan.hak@nic.cz>
Maintainer: Daniel Salzman / @salzmdan
Description: