Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddns-scripts: add colon char in DNS_CHARSET #25056

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ddns-scripts: add colon char in DNS_CHARSET #25056

wants to merge 1 commit into from
+1 −1

Conversation

xxxxxliil
Copy link

@xxxxxliil xxxxxliil commented Sep 29, 2024 •
edited
Loading

Maintainer: @feckert
Compile tested: N/A. (Runtime package script only)
Run tested: (amd64, ibm comp PC, OpenWrt 23.04, tests done)

Description:
IPv6 is separated by : instead of ., so we need to add : in DNS_CHARSET to fix issue #25051 or #25051

Signed-off-by: Xiaolong Zhang xliilQwQ@outlook.com

@xxxxxliil xxxxxliil force-pushed the ipv6-dns-colon-char branch 2 times, most recently from 4e72f23 to 9d8a67f Compare October 1, 2024 21:16
@feckert
Copy link
Member

feckert commented Oct 7, 2024

  • Please bump the PKG_RELEASE by one.
  • Please add a valid Signed-off-by with your correct name.
  • Please add valid commit messages why we need to add ':' to the CHARSET so we could see in Git why we have to add this. A reference to the issue is not enough

@1715173329
Copy link
Member

Please add a space between your last name and first name, thanks.

@xxxxxliil
Copy link
Author

Please add a space between your last name and first name, thanks.

What if there is only first name?

@xxxxxliil
Copy link
Author

@feckert @1715173329 What else do I need to do?

@feckert
Copy link
Member

feckert commented Oct 15, 2024

I do not speak Chinese! But deepl.com says '行旅途' means 'travel destination'.
And I don't know how the names are constructed in china.
CI/CD still complains
These are the rules sorry

@xxxxxliil
Copy link
Author

CI/CD still complains
These are the rules sorry

How do I change to fit the rules?

@1715173329
Copy link
Member

Sign DCO with your legal name, at least, looks legal.
And nowadays I don't think any legal Chinese name does not contain last name.
I guess "行旅途" means "go travel".

@xxxxxliil
Copy link
Author

Sign DCO with your legal name, at least, looks legal.

Can I only sign with my legal name? I would prefer to contribute anonymously.

@1715173329
Copy link
Member

These are the rules sorry

@xxxxxliil
ddns-scripts: add colon char in DNS_CHARSET
f3a9074 
IPv6 is separated by `:` instead of `.`, so we need to add `:` in DNS_CHARSET to fix issue openwrt#25051
or openwrt#25051

Signed-off-by: Xiaolong Zhang <xliilQwQ@outlook.com>
@xxxxxliil
Copy link
Author

These are the rules sorry

sad

@xxxxxliil
Copy link
Author

@feckert @1715173329 If you have time please approve the inspection.

@feckert
Copy link
Member

feckert commented Nov 6, 2024

Looks good. Just a little nit pick, then we can merge. Can you please limit the commit message to 80 characters per line and remove the second mention of #25051. This does not need to be written twice in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxxxxliil @feckert @1715173329