-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nft-qos: rm unnecessary log avoid spam #25132
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
794a6b3
to
669e472
Compare
Maybe good now, please run check again. @neheb |
Signed-off-by: mos ney <mosney@users.noreply.github.com>
Need a PKG_RELEASE bump. |
Looks I need to change GitHub name into 2 words or failed in formalities.
It means I need to edit MAKEFILE PKG_RELEASE:=4 to PKG_RELEASE:=5? |
yes |
But I don't wanna change my GitHub name, so does this mean that I cannot pass the formalities check at all? @neheb |
Why there are already 2 similar PR, which does the same? The first opened is here: https://github.com/openwrt/packages/pull/25122/files |
Don't know, maybe coincidence. I try PR long time ago #24362 but always stuck on formality. |
Maintainer: @neheb @wulfy23 @champtar @lzto @ldir-EDB0 @rosysong
Compile tested: I think it’s don’t needed.
Run tested:
I comment out this logger line in 2 files at
/etc/hotplug.d/dhcp/
on my OpenWrt, and it’s works normally.Description:
Log DHCP info to system log is obviously unnecessary. I found some users in community also complaining about this because sometimes it leads to log spam.
See: https://www.right.com.cn/forum/thread-4091545-1-1.html