Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nft-qos: rm unnecessary log avoid spam #25132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Mosney
Copy link

@Mosney Mosney commented Oct 13, 2024

Maintainer: @neheb @wulfy23 @champtar @lzto @ldir-EDB0 @rosysong

Compile tested: I think it’s don’t needed.

Run tested:

I comment out this logger line in 2 files at /etc/hotplug.d/dhcp/ on my OpenWrt, and it’s works normally.

Description:

Log DHCP info to system log is obviously unnecessary. I found some users in community also complaining about this because sometimes it leads to log spam.
See: https://www.right.com.cn/forum/thread-4091545-1-1.html

@Mosney

This comment was marked as outdated.

@Mosney
Copy link
Author

Mosney commented Oct 13, 2024

Maybe good now, please run check again. @neheb

Signed-off-by: mos ney <mosney@users.noreply.github.com>
@neheb
Copy link
Contributor

neheb commented Oct 14, 2024

Need a PKG_RELEASE bump.

@Mosney
Copy link
Author

Mosney commented Oct 14, 2024

Run source .github/workflows/ci_helpers.sh
: === Checking commit '9b014439673ec63c1f19653850fbeb12c3564c08'
: Author name (Mosney) need to be your real name 'firstname lastname'
: Commit subject line seems ok (nft-qos: rm unnecessary log avoid spam)
: Signed-off-by is missing or doesn't match author (should be 'Signed-off-by: Mosney Mosney@users.noreply.github.com')
Error: Process completed with exit code 1

Looks I need to change GitHub name into 2 words or failed in formalities.

Need a PKG_RELEASE bump.

It means I need to edit MAKEFILE PKG_RELEASE:=4 to PKG_RELEASE:=5?

@neheb
Copy link
Contributor

neheb commented Oct 14, 2024

yes

@Mosney
Copy link
Author

Mosney commented Oct 14, 2024

But I don't wanna change my GitHub name, so does this mean that I cannot pass the formalities check at all? @neheb

@BKPepe
Copy link
Member

BKPepe commented Oct 14, 2024

Why there are already 2 similar PR, which does the same? The first opened is here: https://github.com/openwrt/packages/pull/25122/files

@Mosney
Copy link
Author

Mosney commented Oct 14, 2024

Why there are already 2 similar PR, which does the same? The first opened is here: https://github.com/openwrt/packages/pull/25122/files

Don't know, maybe coincidence. I try PR long time ago #24362 but always stuck on formality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants