tor-hs: refactor + readme fixes #25162
Open
+89
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
systemcrash
force-pushed
the
tor-hs_fixes
branch
from
c893416
to
6efcee4
Compare
|
IMHO it would be better to merge the #21642 |
stokito
reviewed
Oct 17, 2024
| @@ -8,10 +8,11 @@ | |||
| include $(TOPDIR)/rules.mk | |||
|
|
|||
| PKG_NAME:=tor-hs | |||
| PKG_VERSION:=0.0.1 | |||
| PKG_RELEASE:=3 | |||
| PKG_VERSION:=0.0.2 | |||
There was a problem hiding this comment.
A new option (functionality) so we may increase the minor version to v0.1.0
There was a problem hiding this comment.
Your PR can own 0.1. :)
| echo "{" | ||
| echo '"hs-list":[' | ||
|
|
||
| json_init |
There was a problem hiding this comment.
the string concatenation was faster and used less code
| @@ -41,60 +41,54 @@ config_tor() { | |||
| handle_hs_ports_conf() { | |||
| local public_port local_port | |||
| local value="$1" | |||
| local ipv4="$2" | |||
| local ipaddr="$2" | |||
There was a problem hiding this comment.
In fact this may be not an IP but a unix socket and using of them is even more preferable because you can assign permissions.
There was a problem hiding this comment.
There's nothing that prevents ipaddr from holding a socket string.
There was a problem hiding this comment.
Do you suggest a rename?
The changes still produce synonymous output; just a refactor. Including addition of IPv6 (available tor version supports it) Signed-off-by: Paul Donald <newtwen+github@gmail.com>
systemcrash
force-pushed
the
tor-hs_fixes
branch
from
6efcee4
to
a63f331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me / @stokito
Run tested: 23.05.5 x86_64
Description: refactor to clean up init scripts