Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmicrohttpd: make TITLE shorter #25217

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Karlson2k
Copy link
Contributor

Maintainer: @lynxis
Compile tested: not tested
Run tested: not tested

Description: Shorter title, to fix a problem reported here.

Signed-off-by: Evgeny Grin (Karlson2k) <k2k@narod.ru>
@Karlson2k
Copy link
Contributor Author

@neheb, @Neustradamus
As a follow-up for PR #25208

@neheb neheb merged commit ae6d0ab into openwrt:master Oct 28, 2024
13 checks passed
@BKPepe
Copy link
Member

BKPepe commented Oct 29, 2024

Hey @neheb, would you mind merging things that you haven't clearly tested and were not tested by OP either? This is the second time. The previous PR had the same mistake. This one tries to fix it, but it does not help.

  1. Commit description is missing
  • Nitpick: Fixes tag is missing as well
  1. This one does not help.

Steps to reproduce it:

  1. Run make menuconfig
  2. Go to Libraries, find libmicrohttpd - both does not have name, that is caused that TITLE is too long!

Proof:
image

Yep, I applied this commit as it can be seen here:
image

image

Well, this needs 3rd fix as it seems. :-) Testing on production. I like it. #yolo

@Karlson2k
Copy link
Contributor Author

  1. Commit description is missing

  2. This one does not help.

Steps to reproduce it:

Well, this needs 3rd fix as it seems. :-) Testing on production. I like it. #yolo

@BKPepe As this PR made the title even shorter than it was originally, seems that the problem is not related to these PRs, but it was here before any updates/versions bumps.

Looks like you have easy access to the build environment. Can you provide a correct and properly tested patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants