attendedsysupgrade-common: give the uci-defaults script a run level #25234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the init script to '50-attendedsysupgrade', so it is run in the middle of the init sequence, rather than after all the explicitly ordered ones. This allows later scripts, specifically the 99-level ones, to modify the contents of the attendedsysupgrade configuration. Signed-off-by: Eric Fahlgren <ericfahlgren@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @aparcar
Compile tested: x86/64 snapshot
Run tested: x86/64 snapshot
Description:
Move the init script to '50-attendedsysupgrade', so it is run in the middle of the init sequence, rather than after all the explicitly ordered ones. This allows later scripts, specifically the 99-level ones, to modify the contents of the attendedsysupgrade configuration.
A user reported issues with setting values in their ASU-generated custom init script
99-asu-defaults, and it turned out that the attendedsysupgrade-common script was run after everything else. Since it's not really important where it runs, I just chose to put it at 50, seems as good a place as any as long as it's after the custom 99- ones.Ref: https://forum.openwrt.org/t/owut-openwrt-upgrade-tool/200035/191
Our solution there was to rewrite their custom script to source the file, which seems sort of hacky: