-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openthread-br: bump source to 2024-11-20 and add missing dependencies #25412
Conversation
I'll have to investigate this properly. I cannot believe avahi is needed and I absolutely do not want to add that dependency. Unfortunately I am renovating my house and this will have to wait. To anyone with merge privileges on this repository: do not merge this until further notice. |
There is a possibility that adding OT_TARGET_OPENWRT removed avahi client as a mandatory dependency for this. Both were required only on my bpi4 target (and not the other qemu arm target). it did compile a little different after adding it. Would you like me to check? |
Please do. I really don't want avahi and dbus as dependency of this package. |
bbdde7f
to
8c63128
Compare
After removing libavahi and enabling OT_TARGET_OPENWRT, the compilation was successful. wdyt? |
Meh I bought 2 USB sticks to test with this. Never got around to it... |
I will try to test this over the weekend. I am using 3 nanoleaf essential bulbs, an EVE energy, and an Aqara U200 smart lock on my OpenWrt Thread network. If these keep working I'll accept the PR. |
Could you fix the test formalities failure though?
|
And maybe add some of the reasoning you mentioned in the comments for changes in the commit message. |
8c63128
to
5b71b34
Compare
…ndencies Bumping ot-br-posix that openthread-br is based on to latest code. Due to some major changes required some more compilation flags, and in order to avoid the ot-br agent had to add some dependencies as well Dependecies: 1. kmod-tun: otherwise the otbr fails to load and crashed immidiedtly Compilation flags: 1. OTBR_NAT64, OT_NAT64_BORDER_ROUTING set to OFF: a temporary workaround to a compilation problem with openwrt, could be reverted once the issue here is fixed: openthread/ot-br-posix#2606 2. OT_TARGET_OPENWRT: wasn't assumed from OTBR_OPENWRT in some targets Signed-off-by: Itay Shoshani <itai.sho@gmail.com>
5b71b34
to
ecb5fa7
Compare
Worked on the changes you talked about |
Had guests over the weekend, but just tested this and can't spot any immediate regressions. |
Maintainer: @stintel
Compile tested: armsr/armv8/generic, and banana pi r4. both aarch64
Run tested: armsr/armv8/generic, and banana pi r4. both aarch64
I tested it until I saw that the service is up (and not crashing) as it was before
Description:
bumped ot-br-posix that openthread-br is based on to latest code.
the major changes required some more compilation flags, and in order to avoid the ot-br agent had to add some dependencies as weell.
dependencies:
compilation flags: