-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netatalk: update to version 3.1.9 and grab maintainership #3135
Conversation
8e806de
to
0eaa28c
Compare
0eaa28c
to
800a80b
Compare
Well, there was no reaction from the maintainer to the previous pull request for a year, so you should maybe also grab the maintainership... |
My only contribution was to replace +attr with +libattr, so... |
Hm, maybe someone actually owning a Mac to regularly test netatalk would be a better choice for the mainterner job. Anyway, if nobody else volunteers I can still try my best... Ideas? |
* now a single config file in /etc/afp.conf * convert services to procd while at it * take over maintainership as the original maintainer is unresponsive (see openwrt#1550) Signed-off-by: Daniel Golle <daniel@makrotopia.org>
800a80b
to
c0e0e71
Compare
I think it's agreed that we want packages to be actively maintained and I have no objection against the maintainership transfer. The problem is that we still have no written-down conclusion (#153) about when and how a package's maintainership should be transferred. I think a private email to the current maintainer is needed, maybe just for the sake of formality. Sorry guys, the following text is apparently for another issue and I was on the wrong page when clicking "close and comment"...
|
There has been no reaction from the current netatalk maintainer @MikePetullo to the whole discussion, so I would take the silence as an ack. (especially as he did not react to several review requests in #1550 ) Activate maintainers are a necessity. A compromise might be to add you as the second maintainer at this point. Some of the packages have several maintainers mentioned. In general, waiting for an explicit acknowledgement from an inactive maintainer may be futile. We have quite a lot of packages that were imported in the summer 2014 transfer rush, but which packages have not seen any activity from the original maintainer since then. |
Sorry, here I am. I fully support a new maintainer, as I no longer own any computers which run Mac OS X. I apologize if not hearing from me slowed progress on this. |
Doesn't build: |
@usr-sse2: It does build on the buildbots, what you describe looks like a toolchain problem. Which version of OpenWrt/LEDE are you using? |
@dangowrt, I'm using OpenWRT 15.05. |
@dangowrt, unfortunately, it doesn't build also, but with a different error: ^ I looked at that file, there is an empty line. If I remove it, the error remains, saying about the next line. The line before the empty line is #include <stdlib.h>, what can be wrong with that... |
Updated by: |
Maintainer: @MikePetullo
Compile tested: oxnas/generic, LEDE git HEAD
Run tested: oxnas/generic, LEDE git HEAD
Description:
Signed-off-by: Daniel Golle daniel@makrotopia.org