Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coapserver-coaphandler: Restore feature parity with coapserver #239

Conversation

chrysn
Copy link
Collaborator

@chrysn chrysn commented Mar 7, 2024

authz support was added to the coapserver but not to coapserver-coaphandler; this fixes the regression.

This is based on #238 because the C client's bugs were hidden by coapserver's lax handling (see martindisch/coap-lite#36), and would otherwise make it unusable for even basic testing.

chrysn added 3 commits March 6, 2024 22:20
While the coap crate does tolerate such requests to a
not-wrong-but-different-and-clearly-unintended resource, the coaphandler
based implementation is stricter.
@geonnave
Copy link
Collaborator

geonnave commented Mar 8, 2024

Looks good, thanks for this PR.

@geonnave geonnave merged commit 95677a2 into openwsn-berkeley:main Mar 8, 2024
27 checks passed
@geonnave geonnave added the enhancement New feature or request label Mar 13, 2024
@chrysn chrysn deleted the coapserver-coaphandler-authz branch April 11, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants