Skip to content

Commit

Permalink
Add type information to DSPX bidResponse (prebid#5021)
Browse files Browse the repository at this point in the history
* Add type information to DSPX bidResponse

Depending on the ad type other ad placements can be blocked or not.
For example a Skin Ad may require that all skys are blocked so they
don't overlap. For a regular display banner this isn't necessary.

* Add type to unit test

* Revert "Add type information to DSPX bidResponse"

This reverts commit 9403cea.

* Add type information to DSPX bidResponse

Depending on the ad type other ad placements can be blocked or not.
For example a Skin Ad may require that all skys are blocked so they
don't overlap. For a regular display banner this isn't necessary.

* Revert "Add type to unit test"

This reverts commit c08ce99.

* Add type to unit test
  • Loading branch information
muuki88 authored and rjvelicaria committed Apr 9, 2020
1 parent d6cea38 commit 0cc4efb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions modules/dspxBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export const spec = {
dealId: dealId,
currency: currency,
netRevenue: netRevenue,
type: response.type,
ttl: config.getConfig('_bidderTimeout'),
ad: response.adTag
};
Expand Down
2 changes: 2 additions & 0 deletions test/spec/modules/dspxBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ describe('dspxAdapter', function () {
'crid': 100500,
'width': '300',
'height': '250',
'type': 'sspHTML',
'tag': '<!-- test creative -->',
'requestId': '220ed41385952a',
'currency': 'EUR',
Expand All @@ -127,6 +128,7 @@ describe('dspxAdapter', function () {
currency: 'EUR',
netRevenue: true,
ttl: 300,
type: 'sspHTML',
ad: '<!-- test creative -->'
}];

Expand Down

0 comments on commit 0cc4efb

Please sign in to comment.