Merge pull request #25 from openx/cleanup-normalize-video-ad-size

clean(openxBidderAdaptor): converted video size to numbers from strin…
openx · May 15, 2020 · 276ef43 · 276ef43
2 parents 2621343 + bc4217b
commit 276ef43
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 22 deletions.
diff --git a/modules/openxBidAdapter.js b/modules/openxBidAdapter.js
@@ -422,7 +422,7 @@ function generateVideoParameters(bid, bidderRequest) {
 function createVideoBidResponses(response, {bid, startTime}) {
   let bidResponses = [];
 
-  if (response !== undefined && response.vastUrl !== '' && response.pub_rev !== '') {
+  if (response !== undefined && response.vastUrl !== '' && response.pub_rev > 0) {
     let vastQueryParams = utils.parseUrl(response.vastUrl).search || {};
     let bidResponse = {};
     bidResponse.requestId = bid.bidId;
@@ -431,9 +431,9 @@ function createVideoBidResponses(response, {bid, startTime}) {
     // true is net, false is gross
     bidResponse.netRevenue = true;
     bidResponse.currency = response.currency;
-    bidResponse.cpm = Number(response.pub_rev) / 1000;
-    bidResponse.width = response.width;
-    bidResponse.height = response.height;
+    bidResponse.cpm = parseInt(response.pub_rev, 10) / 1000;
+    bidResponse.width = parseInt(response.width, 10);
+    bidResponse.height = parseInt(response.height, 10);
     bidResponse.creativeId = response.adid;
     bidResponse.vastUrl = response.vastUrl;
     bidResponse.mediaType = VIDEO;

diff --git a/test/spec/modules/openxBidAdapter_spec.js b/test/spec/modules/openxBidAdapter_spec.js
@@ -1155,7 +1155,7 @@ describe('OpenxAdapter', function () {
           'bidderRequestId': '22edbae2733bf6',
           'auctionId': '1d1a030790a475',
           'transactionId': '4008d88a-8137-410b-aa35-fbfdabcb478e'
-        }
+        };
         mockBidderRequest = {refererInfo: {}};
       });
 
@@ -1587,32 +1587,31 @@ describe('OpenxAdapter', function () {
       payload: {'bid': bidsWithMediaType[0], 'startTime': new Date()}
     };
     const bidResponse = {
-      'pub_rev': '1',
+      'pub_rev': '1000',
       'width': '640',
       'height': '480',
       'adid': '5678',
-      'vastUrl': 'https://testvast.com/vastpath?colo=https://test-colo.com&ph=test-ph&ts=test-ts',
+      'currency': 'AUD',
+      'vastUrl': 'https://testvast.com',
       'pixels': 'https://testpixels.net'
     };
 
     it('should return correct bid response with MediaTypes', function () {
-      const expectedResponse = [
-        {
-          'requestId': '30b31c1838de1e',
-          'cpm': 1,
-          'width': '640',
-          'height': '480',
-          'mediaType': 'video',
-          'creativeId': '5678',
-          'vastUrl': 'https://testvast.com',
-          'ttl': 300,
-          'netRevenue': true,
-          'currency': 'USD'
-        }
-      ];
+      const expectedResponse = {
+        'requestId': '30b31c1838de1e',
+        'cpm': 1,
+        'width': 640,
+        'height': 480,
+        'mediaType': 'video',
+        'creativeId': '5678',
+        'vastUrl': 'https://testvast.com',
+        'ttl': 300,
+        'netRevenue': true,
+        'currency': 'AUD'
+      };
 
       const result = spec.interpretResponse({body: bidResponse}, bidRequestsWithMediaTypes);
-      expect(JSON.stringify(Object.keys(result[0]).sort())).to.eql(JSON.stringify(Object.keys(expectedResponse[0]).sort()));
+      expect(result[0]).to.eql(expectedResponse);
     });
 
     it('should return correct bid response with MediaType', function () {