Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up lint failures #31

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Cleaned up lint failures #31

merged 1 commit into from
Jun 4, 2020

Conversation

jimee02
Copy link

@jimee02 jimee02 commented Jun 4, 2020

  • Removed unused variables
  • Removed ?.
  • Added JSDoc so we don't have to lookup the types in the future

@jimee02 jimee02 requested a review from hrgui June 4, 2020 06:14
@hrgui hrgui merged commit 5abf46d into openx-adapter Jun 4, 2020
@hrgui hrgui deleted the lint-cleanup branch June 4, 2020 23:01
laurb9 pushed a commit that referenced this pull request Jul 20, 2021
@SublimeJeremy
Sublime Bid Adapter : send notid in pixel & use timeout from timeoutD…
4d38732 
…ata (prebid#7167)

* DL-1746: Remove trId and use notid instead (#31)

* Remove trId and use notid instead
* Update version to 0.7.3
* Set default value to empty string

Co-authored-by: SublimeJeremy <jeremy@sublimeskinz.com>

* DL-1780: Fix pubtimeout (#32)

* Update timeout value with onTimeout data
* Add test for onTimeout
* Update state with timeout asap

Co-authored-by: SublimeJeremy <jeremy@sublimeskinz.com>
laurb9 pushed a commit that referenced this pull request Jul 30, 2024
@nickllerandi @klawil
Kargo Bid Adapter: test spec overhaul (prebid#11417)
ecb9218 
* KRKPD-1083: Refactor and expand testing (#31)

* Refactor the Kargo adapter testing to be more comprehensive and include testing of invalid inputs

* Fix the window size test to pull data from the browser instead of hardcoded values

* Remove a duplicate test

* unhook triggerPixel after tests

* fixes circleci failure

* Update the localStorage non-functional test

In FireFox, having localStorage.getItem throw an error isn't working so the test was updated to not have a valid localStorage
value to pass on FireFox.

* Restore the bidderSettings following testing

---------

Co-authored-by: William Klausmeyer <klawil@users.noreply.github.com>
Co-authored-by: “Nick <“nick.llerandi”@kargo.com>
Co-authored-by: William Klausmeyer <willyk95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrgui hrgui Awaiting requested review from hrgui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimee02 @hrgui