OpenX adapter: update documentation #52
Conversation
… hint for using floor module
marcin-wrobel-ox
force-pushed
the
chore/update-doc
branch
from
0a35514 to
f131a96
Compare
|
@marcin-wrobel-ox you may want to against master, this is unreviewable |
| | `coppa` | optional | Boolean | Enables Child's Online Privacy Protection Act (COPPA) regulations. | true | ||
| | Name | Scope | Type | Description | Example | ||
| |---------------------------------| ----- | ---- |------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| ------- | ||
| | `delDomain` ~~or `platform`~~** | required | String | OpenX delivery domain provided by your OpenX representative. | "PUBLISHER-d.openx.net" |
There was a problem hiding this comment.
are we deprecating platform?
obviously it was
There was a problem hiding this comment.
I would actually have deprecated the delDomain because people always mess up with the UI domain name
also neither are really needed per se because adunit is unique across platform anyway
There was a problem hiding this comment.
true, I saw numerous ad requests with ui domain instead of del domain
There was a problem hiding this comment.
@kenan-gillet @marcin-wrobel-ox actually i believe @lambdarho was telling me that delDomain is actually preferred because using platform does not cookie sync as well
| | `delDomain` ~~or `platform`~~** | required | String | OpenX delivery domain provided by your OpenX representative. | "PUBLISHER-d.openx.net" | ||
| | `unit` | required | String | OpenX ad unit ID provided by your OpenX representative. | "1611023122" | ||
| | `customParams` | optional | Object | User-defined targeting key-value pairs. customParams applies to a specific unit. | `{key1: "v1", key2: ["v2","v3"]}` | ||
| | `customFloor` | optional | Number | Minimum price in USD. customFloor applies to a specific unit. For example, use the following value to set a $1.50 floor: 1.50 <br/><br/> **WARNING:**<br/> Misuse of this parameter can impact revenue<br/><br/>Note: OpenX suggests using the [Price Floor Module](https://docs.prebid.org/dev-docs/modules/floors.html) instead of customFloor. The Price Floor Module will be prioritized over customFloor if both are present. | 1.50 |
There was a problem hiding this comment.
will be prioritized is it true now or in the future ?
if true now, is prioritized instead of will be prioritized seems less ambiguous
There was a problem hiding this comment.
good point, it is already happening, since PR was merged in an upstream I will keep in mind to change it next time
|
It was merged to upstream, so closing this |
Type of change
Description of change
Update documentation about the deprecated bid param platform.
Add a hint to use Price Floor Module instead of customFloor param.