Avoid explicitly constructing compatible attributes in a few places (#…

…1958)

Attrs will be implicitly copied. Avoid explicitly constructing the attrs
as this introduces a dependency on the type of the attrs, meaning the
code will need to be changed if the attrs' type changes. (Indeed I had
to change this code recently when we changed the attrs from
DenseIntElementsAttr to DenseI64ArrayAttr).

stablehlo/conversions/linalg/transforms/StablehloLegalizeToLinalg.cpp

@@ -831,11 +831,8 @@ struct TransposeOpToTransposeConverter final
     Value emptyTensor =
         getEmptyTensorFor(rewriter, loc, resultTy, op, adaptor.getOperands());
 
-    auto permutation =
-        rewriter.getDenseI64ArrayAttr(llvm::to_vector(op.getPermutation()));
-
     rewriter.replaceOpWithNewOp<linalg::TransposeOp>(
-        op, adaptor.getOperand(), emptyTensor, permutation,
+        op, adaptor.getOperand(), emptyTensor, op.getPermutationAttr(),
         linalg::getPrunedAttributeList(op));
     return success();
   }

stablehlo/transforms/StablehloCanonicalizeDynamism.cpp

@@ -111,8 +111,7 @@ struct CanonicalizeDynamicBroadcastInDimOpPattern
     if (!op.getType().hasStaticShape())
       return rewriter.notifyMatchFailure(op, "expected static result type");
     rewriter.replaceOpWithNewOp<BroadcastInDimOp>(
-        op, op.getType(), op.getOperand(),
-        rewriter.getDenseI64ArrayAttr(op.getBroadcastDimensions()));
+        op, op.getType(), op.getOperand(), op.getBroadcastDimensionsAttr());
     return success();
   }
 };