Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for opset change contributions to CONTRIBUTING.md #1921

Merged
merged 7 commits into from
Jan 29, 2024

Conversation

GleasonK
Copy link
Member

@GleasonK GleasonK commented Jan 16, 2024

Although the RFC process under OpenXLA is not fully standardized yet, there have been a few changes to StableHLO lately which had success using a similar process. This PR adds some documentation on the steps they followed to contributing.md.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@ghpvnist ghpvnist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc could turn out to be the SoT for all of the contributions needed touching any StableHLO codebase, so let's link all applicable docs here.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Copy link
Member

@ghpvnist ghpvnist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@ghpvnist ghpvnist assigned GleasonK and unassigned ghpvnist Jan 26, 2024
@GleasonK GleasonK merged commit bfea422 into openxla:main Jan 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants