Use bash strict mode in license check script #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlevesquedion
force-pushed
the
use-bash-strict-mode-for-license-check
branch
from
5bac67b
to
1eb89c1
Compare
Also, change the condition on whether UNLICENSED_FILES contains any elements to avoid triggering nounset.
mlevesquedion
force-pushed
the
use-bash-strict-mode-for-license-check
branch
from
1eb89c1
to
a8485db
Compare
abhigunj
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added the script in #2018, I bootstrapped it from a script that didn't use strict mode. Around the same time, I sent #2012 for review, but forgot to apply the change to this new script as well.
Also, change the condition on whether UNLICENSED_FILES contains any
elements to avoid triggering nounset.