Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bash strict mode in license check script #2038

Conversation

mlevesquedion
Copy link
Contributor

@mlevesquedion mlevesquedion commented Feb 23, 2024

When I added the script in #2018, I bootstrapped it from a script that didn't use strict mode. Around the same time, I sent #2012 for review, but forgot to apply the change to this new script as well.

Also, change the condition on whether UNLICENSED_FILES contains any
elements to avoid triggering nounset.

@mlevesquedion mlevesquedion force-pushed the use-bash-strict-mode-for-license-check branch from 5bac67b to 1eb89c1 Compare February 23, 2024 02:50
Also, change the condition on whether UNLICENSED_FILES contains any
elements to avoid triggering nounset.
@mlevesquedion mlevesquedion merged commit 4e463ed into openxla:main Feb 23, 2024
10 checks passed
@mlevesquedion mlevesquedion deleted the use-bash-strict-mode-for-license-check branch February 23, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants