[Cleanup] Use push_back instead of emplace_back where appropriate (go…

…/totw/112) PiperOrigin-RevId: 706713654
openxla · Dec 19, 2024 · 9957144 · 9957144
1 parent ca3ddd2
commit 9957144
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 11 deletions.
diff --git a/xla/hlo/builder/lib/comparators.cc b/xla/hlo/builder/lib/comparators.cc
@@ -74,8 +74,8 @@ XlaComputation CreateScalarComparisonComputation(
                                absl::StrCat("p.", parameter_count, ".lhs"));
     auto rhs_param = Parameter(b.get(), parameter_count * 2 + 1, scalar_shape,
                                absl::StrCat("p.", parameter_count, ".rhs"));
-    lhs_params.emplace_back(lhs_param);
-    rhs_params.emplace_back(rhs_param);
+    lhs_params.push_back(lhs_param);
+    rhs_params.push_back(rhs_param);
     if (generators[parameter_count].has_value()) {
       last_generator_index = parameter_count;
     }

diff --git a/xla/hlo/builder/xla_builder.cc b/xla/hlo/builder/xla_builder.cc
@@ -3456,7 +3456,7 @@ XlaOp XlaBuilder::ConditionalImpl(
 
     std::vector<XlaOp> operands(1, branch_index);
     for (const XlaOp branch_operand : branch_operands) {
-      operands.emplace_back(branch_operand);
+      operands.push_back(branch_operand);
     }
     return AddInstruction(std::move(instr), HloOpcode::kConditional,
                           absl::MakeSpan(operands));

diff --git a/xla/hlo/ir/hlo_computation.cc b/xla/hlo/ir/hlo_computation.cc
@@ -1728,7 +1728,7 @@ std::unique_ptr<HloComputation> HloComputation::CloneInContext(
       for (HloInstruction* operand : cur->operands()) {
         const HloInstruction* new_operand = replace(operand);
         if (new_operand) {
-          dfs_stack.emplace_back(new_operand);
+          dfs_stack.push_back(new_operand);
         }
       }
     }

diff --git a/xla/hlo/parser/hlo_parser.cc b/xla/hlo/parser/hlo_parser.cc
@@ -6629,7 +6629,7 @@ bool HloParserImpl::ParseListShardingType(
       if (!ParseOpShardingType(&type)) {
         return false;
       }
-      types->emplace_back(type);
+      types->push_back(type);
     } while (EatIfPresent(TokKind::kComma));
   }
 

diff --git a/xla/hlo/transforms/collectives/collective_quantizer.cc b/xla/hlo/transforms/collectives/collective_quantizer.cc
@@ -148,7 +148,7 @@ std::vector<HloInstruction*> FindDequantizationSubgraphRecursive(
     return {};
   }
 
-  subgraph.emplace_back(instr);
+  subgraph.push_back(instr);
   if (Match(instr, ConvertToWiderType())) {
     return subgraph;
   }
@@ -231,15 +231,15 @@ std::optional<ConversionSubgraph> IsSupportedQuantization(
                          BitcastPreservesElementType(), m::Copy(), m::Reshape(),
                          m::Slice(), m::Multiply(), m::Divide(), m::Clamp()))) {
       if (instr->user_count() > 0) {
-        ops.emplace_back(instr);
+        ops.push_back(instr);
         instr = instr->users()[0];
         continue;
       }
       break;
     }
 
     if (Match(instr, ConvertToNarrowerType())) {
-      ops.emplace_back(instr);
+      ops.push_back(instr);
       break;
     }
     VLOG(5) << "Unsupported instruction.";

diff --git a/xla/hlo/transforms/host_offloader.cc b/xla/hlo/transforms/host_offloader.cc
@@ -855,7 +855,7 @@ absl::StatusOr<bool> UpdateMemorySpaceForHostOffloadedOutputs(
       // If instruction is MoveToHost, we will replace usage.
       if (instr_and_shape.instruction->IsCustomCall(
               host_memory_offload_annotations::kMoveToHostCustomCallTarget)) {
-        to_replace.emplace_back(instr_and_shape);
+        to_replace.push_back(instr_and_shape);
         continue;
       }
 
@@ -1014,7 +1014,7 @@ absl::StatusOr<bool> HostOffloader::HandleRedundantCopiesBackToHost(
 
             queue.push(successor);
             host_instrs_tree.mutable_element(output_shape_index)
-                ->emplace_back(successor);
+                ->push_back(successor);
           }
         }
 

diff --git a/xla/hlo/transforms/simplifiers/float_normalization.cc b/xla/hlo/transforms/simplifiers/float_normalization.cc
@@ -259,7 +259,7 @@ absl::Status FloatNormalizationVisitor::ChangeOutputTypeThenInsertConvertBack(
     if (allow_excess_precision && user->opcode() == HloOpcode::kConvert &&
         user->shape().element_type() == to && to == HighPrecisionType() &&
         from == LowPrecisionType()) {
-      conversions_to_simplify.emplace_back(user);
+      conversions_to_simplify.push_back(user);
     } else {
       TF_RETURN_IF_ERROR(hlo->ReplaceUseWithDifferentShape(user, new_hlo));
     }