-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] Remove IsEmpty check for execution_order introduced in c3d5769
#18860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsharsha
changed the title
[ROCm] Remove IsEmpty check for execution_order introduced in c3d5769
[ROCm] Remove IsEmpty check for execution_order introduced in Oct 30, 2024
c3d5769
beckerhe
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
… in `c3d5769` Imported from GitHub PR #18860 Copybara import of the project: -- 1b61efe by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Remove IsEmpty check for execution_order introduced in c3d5769 Merging this change closes #18860 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18860 from ROCm:ci_fix_rocm_stream_test_20241030 1b61efe PiperOrigin-RevId: 691517601
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 30, 2024
… in `c3d5769` Imported from GitHub PR openxla/xla#18860 Copybara import of the project: -- 1b61efe8270e67140199bbbb70665955fbaa6656 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Remove IsEmpty check for execution_order introduced in c3d5769 Merging this change closes #18860 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18860 from ROCm:ci_fix_rocm_stream_test_20241030 1b61efe8270e67140199bbbb70665955fbaa6656 PiperOrigin-RevId: 691517601
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
… in `c3d5769` Imported from GitHub PR #18860 Copybara import of the project: -- 1b61efe by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Remove IsEmpty check for execution_order introduced in c3d5769 Merging this change closes #18860 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18860 from ROCm:ci_fix_rocm_stream_test_20241030 1b61efe PiperOrigin-RevId: 691517601
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 31, 2024
… in `c3d5769` Imported from GitHub PR openxla/xla#18860 Copybara import of the project: -- 1b61efe8270e67140199bbbb70665955fbaa6656 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Remove IsEmpty check for execution_order introduced in c3d5769 Merging this change closes #18860 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18860 from ROCm:ci_fix_rocm_stream_test_20241030 1b61efe8270e67140199bbbb70665955fbaa6656 PiperOrigin-RevId: 691517601
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 31, 2024
… in `c3d5769` Imported from GitHub PR openxla/xla#18860 Copybara import of the project: -- 1b61efe8270e67140199bbbb70665955fbaa6656 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Remove IsEmpty check for execution_order introduced in c3d5769 Merging this change closes #18860 PiperOrigin-RevId: 691744865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.